From: Cornelia Huck <cohuck@redhat.com>
To: Collin Walling <walling@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Richard Henderson <rth@twiddle.net>,
David Hildenbrand <david@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>,
qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH for-4.1 1/2] s390x/pci: add some fallthrough annotations
Date: Mon, 8 Jul 2019 14:54:32 +0200 [thread overview]
Message-ID: <20190708125433.16927-2-cohuck@redhat.com> (raw)
In-Reply-To: <20190708125433.16927-1-cohuck@redhat.com>
According to the comment, the bits are supposed to accumulate.
Reported-by: Stefan Weil <sw@weilnetz.de>
Fixes: 5d1abf234462 ("s390x/pci: enforce zPCI state checking")
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
hw/s390x/s390-pci-inst.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index 61f30b8e55d2..00235148bed7 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -1209,8 +1209,10 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba, uint8_t ar,
* FH Enabled bit is set to one in states of ENABLED, BLOCKED or ERROR. */
case ZPCI_FS_ERROR:
fib.fc |= 0x20;
+ /* fallthrough */
case ZPCI_FS_BLOCKED:
fib.fc |= 0x40;
+ /* fallthrough */
case ZPCI_FS_ENABLED:
fib.fc |= 0x80;
if (pbdev->iommu->enabled) {
--
2.20.1
next prev parent reply other threads:[~2019-07-08 12:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 12:54 [Qemu-devel] [PATCH for-4.1 0/2] s390x: fallthrough annotations Cornelia Huck
2019-07-08 12:54 ` Cornelia Huck [this message]
2019-07-08 13:23 ` [Qemu-devel] [PATCH for-4.1 1/2] s390x/pci: add some " Christian Borntraeger
2019-07-09 22:55 ` [Qemu-devel] [qemu-s390x] " Collin Walling
2019-07-10 8:20 ` Cornelia Huck
2019-07-16 15:20 ` Cornelia Huck
2019-07-16 18:34 ` Collin Walling
2019-07-17 8:54 ` Cornelia Huck
2019-07-17 9:27 ` Christian Borntraeger
2019-07-17 12:52 ` Collin Walling
2019-07-18 9:41 ` Cornelia Huck
2019-07-08 12:54 ` [Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotation Cornelia Huck
2019-07-08 13:27 ` Stefan Weil
2019-07-16 15:22 ` Philippe Mathieu-Daudé
2019-07-16 15:26 ` Cornelia Huck
2019-07-09 8:39 ` [Qemu-devel] [PATCH for-4.1 0/2] s390x: fallthrough annotations Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708125433.16927-2-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).