From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 4/6] block/qcow: Improve error when opening qcow2 files as qcow
Date: Mon, 8 Jul 2019 16:18:10 +0200 [thread overview]
Message-ID: <20190708141812.3974-5-kwolf@redhat.com> (raw)
In-Reply-To: <20190708141812.3974-1-kwolf@redhat.com>
From: John Snow <jsnow@redhat.com>
Reported-by: radmehrsaeed7@gmail.com
Fixes: https://bugs.launchpad.net/bugs/1832914
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/block/qcow.c b/block/qcow.c
index 6dee5bb792..5bdf72ba33 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -156,7 +156,12 @@ static int qcow_open(BlockDriverState *bs, QDict *options, int flags,
goto fail;
}
if (header.version != QCOW_VERSION) {
- error_setg(errp, "Unsupported qcow version %" PRIu32, header.version);
+ error_setg(errp, "qcow (v%d) does not support qcow version %" PRIu32,
+ QCOW_VERSION, header.version);
+ if (header.version == 2 || header.version == 3) {
+ error_append_hint(errp, "Try the 'qcow2' driver instead.\n");
+ }
+
ret = -ENOTSUP;
goto fail;
}
--
2.20.1
next prev parent reply other threads:[~2019-07-08 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 14:18 [Qemu-devel] [PULL 0/6] Block layer patches Kevin Wolf
2019-07-08 14:18 ` [Qemu-devel] [PULL 1/6] vl: add qemu_add_vm_change_state_handler_prio() Kevin Wolf
2019-07-08 14:18 ` [Qemu-devel] [PULL 2/6] qdev: add qdev_add_vm_change_state_handler() Kevin Wolf
2019-07-08 14:18 ` [Qemu-devel] [PULL 3/6] virtio-scsi: restart DMA after iothread Kevin Wolf
2019-07-08 14:18 ` Kevin Wolf [this message]
2019-07-08 14:18 ` [Qemu-devel] [PULL 5/6] MAINTAINERS: update RBD block maintainer Kevin Wolf
2019-07-08 14:18 ` [Qemu-devel] [PULL 6/6] qcow2: Allow -o compat=v3 during qemu-img amend Kevin Wolf
2019-07-08 15:12 ` [Qemu-devel] [PULL 0/6] Block layer patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708141812.3974-5-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).