From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB144C606B0 for ; Tue, 9 Jul 2019 06:13:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC11921537 for ; Tue, 9 Jul 2019 06:13:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC11921537 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkjNv-0000nJ-On for qemu-devel@archiver.kernel.org; Tue, 09 Jul 2019 02:13:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57544) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkjN2-0000J5-VY for qemu-devel@nongnu.org; Tue, 09 Jul 2019 02:12:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkjN1-0002jS-Hd for qemu-devel@nongnu.org; Tue, 09 Jul 2019 02:12:56 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:46295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkjN1-0002io-Bi for qemu-devel@nongnu.org; Tue, 09 Jul 2019 02:12:55 -0400 Received: by mail-pf1-f196.google.com with SMTP id c73so4092177pfb.13 for ; Mon, 08 Jul 2019 23:12:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nvrrdFwLavFegQ89jBa6tFS05TG/raQM37KhZRycP+U=; b=jKawuw/VjZ/t4jUiuEMZJ/D9TEKZWd55IsEYqeQGcJhyB0HsfUH3M0bM5KO9YsU+m0 DDrfa6+4atsISJtNUjbtMssXDIzZVU87NvBzgWfmyNi2vXZkP8KOnoxM7ONAEr0XLn08 qw/8KHYioUhW3XuLDzZwQbJpBfeAw7FbKczgv6bNutjrbWMBizQ6huSeMI6yM5eyU+rW 1/GGv3xnm16qK0a9L+haM793wJp1ybggRWyzGXCsP/9NeSYkFoqxpidWxxPYAzQUVrjs o+5vASUP+Q45GspVqUwburURwzbQrLC/4yrH9q08/FnV3EgKk7/nQhBXlructx/qK7Um a0lA== X-Gm-Message-State: APjAAAXVyp2froorafo6EhgrRBPifEV6wlGoN7gpFnfU/d6Vxbl0j5qU le9t+e600r61VQbTAXwMgG0qzQ== X-Google-Smtp-Source: APXvYqw/Xmo/GQdncSlnPMpnScbCTZIkWo24q1AKPaW+ouX5tU2i+uKwkwvTaM1mb1pqSkIInxZajQ== X-Received: by 2002:a17:90a:fe5:: with SMTP id 92mr14385283pjz.35.1562652772796; Mon, 08 Jul 2019 23:12:52 -0700 (PDT) Received: from xz-x1 ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id p13sm2739247pjb.30.2019.07.08.23.12.47 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Jul 2019 23:12:51 -0700 (PDT) From: Peter Xu X-Google-Original-From: Peter Xu Date: Tue, 9 Jul 2019 14:12:40 +0800 To: Liu Yi L Message-ID: <20190709061240.GF5178@xz-x1> References: <1562324511-2910-1-git-send-email-yi.l.liu@intel.com> <1562324511-2910-11-git-send-email-yi.l.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1562324511-2910-11-git-send-email-yi.l.liu@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.210.196 Subject: Re: [Qemu-devel] [RFC v1 10/18] intel_iommu: tag VTDAddressSpace instance with PASID X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tianyu.lan@intel.com, kevin.tian@intel.com, Jacob Pan , Yi Sun , kvm@vger.kernel.org, mst@redhat.com, jun.j.tian@intel.com, qemu-devel@nongnu.org, eric.auger@redhat.com, alex.williamson@redhat.com, pbonzini@redhat.com, yi.y.sun@intel.com, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 05, 2019 at 07:01:43PM +0800, Liu Yi L wrote: > This patch introduces new fields in VTDAddressSpace for further PASID support > in Intel vIOMMU. In old time, each device has a VTDAddressSpace instance to > stand for its guest IOVA address space when vIOMMU is enabled. However, when > PASID is exposed to guest, device will have multiple address spaces which > are tagged with PASID. To suit this change, VTDAddressSpace should be tagged > with PASIDs in Intel vIOMMU. > > To record PASID tagged VTDAddressSpaces, a hash table is introduced. The > data in the hash table can be used for future sanity check and retrieve > previous PASID configs of guest and also future emulated SVA DMA support > for emulated SVA capable devices. The lookup key is a string and its format > is as below: > > "rsv%04dpasid%010dsid%06d" -- totally 32 bytes Can we make it simply a struct? struct pasid_key { uint32_t pasid; uint16_t sid; } Also I think we don't need to keep reserved bits because it'll be a structure that'll only be used by QEMU so we can extend it easily in the future when necessary. [...] > +static int vtd_pasid_cache_dsi(IntelIOMMUState *s, uint16_t domain_id) > +{ > + VTDPASIDCacheInfo pc_info; > + > + trace_vtd_pasid_cache_dsi(domain_id); > + > + pc_info.flags = VTD_PASID_CACHE_DOMSI; > + pc_info.domain_id = domain_id; > + > + /* > + * use g_hash_table_foreach_remove(), which will free the > + * vtd_pasid_as instances. > + */ > + g_hash_table_foreach_remove(s->vtd_pasid_as, vtd_flush_pasid, &pc_info); > + /* > + * TODO: Domain selective PASID cache invalidation > + * may be issued wrongly by programmer, to be safe, > + * after invalidating the pasid caches, emulator > + * needs to replay the pasid bindings by walking guest > + * pasid dir and pasid table. > + */ It seems to me that this is still unchanged for the whole series. It's fine for RFC, but just a reminder that please either comment on why we don't have something or implement what we need here... [...] > /* Unmap the whole range in the notifier's scope. */ > static void vtd_address_space_unmap(VTDAddressSpace *as, IOMMUNotifier *n) > { > @@ -3914,6 +4076,8 @@ static void vtd_realize(DeviceState *dev, Error **errp) > g_free, g_free); > s->vtd_as_by_busptr = g_hash_table_new_full(vtd_uint64_hash, vtd_uint64_equal, > g_free, g_free); > + s->vtd_pasid_as = g_hash_table_new_full(&g_str_hash, &g_str_equal, > + g_free, hash_pasid_as_free); Can use g_free() and drop hash_pasid_as_free()? Also, this patch only tries to drop entries of the hash table but the hash table is never inserted or used. I would suggest that you put that part to be with this patch as a whole otherwise it's hard to clarify how this hash table will be used. Regards, -- Peter Xu