From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Alistair Francis <alistair.francis@wdc.com>
Subject: [Qemu-devel] [PULL 2/3] tcg/riscv: Fix RISC-VH host build failure
Date: Tue, 9 Jul 2019 09:50:41 +0200 [thread overview]
Message-ID: <20190709075042.13941-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190709075042.13941-1-richard.henderson@linaro.org>
From: Alistair Francis <alistair.francis@wdc.com>
Commit 269bd5d8 "cpu: Move the softmmu tlb to CPUNegativeOffsetState'
broke the RISC-V host build as there are two variables that are used but
not defined.
This patch renames the undefined variables mask_off and table_off to the
existing (but unused) mask_ofs and table_ofs variables.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <79729cc88ca509e08b5c4aa0aa8a52847af70c0f.1561039316.git.alistair.francis@wdc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/riscv/tcg-target.inc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tcg/riscv/tcg-target.inc.c b/tcg/riscv/tcg-target.inc.c
index 1f0ae64aae..3e76bf5738 100644
--- a/tcg/riscv/tcg-target.inc.c
+++ b/tcg/riscv/tcg-target.inc.c
@@ -980,8 +980,8 @@ static void tcg_out_tlb_load(TCGContext *s, TCGReg addrl,
int table_ofs = fast_ofs + offsetof(CPUTLBDescFast, table);
TCGReg mask_base = TCG_AREG0, table_base = TCG_AREG0;
- tcg_out_ld(s, TCG_TYPE_PTR, TCG_REG_TMP0, mask_base, mask_off);
- tcg_out_ld(s, TCG_TYPE_PTR, TCG_REG_TMP1, table_base, table_off);
+ tcg_out_ld(s, TCG_TYPE_PTR, TCG_REG_TMP0, mask_base, mask_ofs);
+ tcg_out_ld(s, TCG_TYPE_PTR, TCG_REG_TMP1, table_base, table_ofs);
tcg_out_opc_imm(s, OPC_SRLI, TCG_REG_TMP2, addrl,
TARGET_PAGE_BITS - CPU_TLB_ENTRY_BITS);
--
2.17.1
next prev parent reply other threads:[~2019-07-09 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 7:50 [Qemu-devel] [PULL v2 for-4.1 0/2] tcg patch queue Richard Henderson
2019-07-09 7:50 ` [Qemu-devel] [PULL 1/3] tcg: Fix mmap lock assert on translation failure Richard Henderson
2019-07-09 7:50 ` [Qemu-devel] [PULL v2 1/2] tcg/riscv: Fix RISC-VH host build failure Richard Henderson
2019-07-09 7:50 ` [Qemu-devel] [PULL v2 2/2] tcg: Fix expansion of INDEX_op_not_vec Richard Henderson
2019-07-09 7:50 ` Richard Henderson [this message]
2019-07-09 7:50 ` [Qemu-devel] [PULL 3/3] " Richard Henderson
2019-07-09 11:46 ` [Qemu-devel] [PULL v2 for-4.1 0/2] tcg patch queue Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2019-07-02 15:05 [Qemu-devel] [PULL 0/3] " Richard Henderson
2019-07-02 15:05 ` [Qemu-devel] [PULL 2/3] tcg/riscv: Fix RISC-VH host build failure Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709075042.13941-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).