From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: lvivier@redhat.com, peter.maydell@linaro.org,
alex.bennee@linaro.org, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH v2 4/5] tcg: Remove duplicate #if !defined(CODE_ACCESS)
Date: Tue, 9 Jul 2019 18:36:55 +0200 [thread overview]
Message-ID: <20190709163656.3100-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20190709163656.3100-1-richard.henderson@linaro.org>
This code block is already surrounded by #ifndef CODE_ACCESS.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/cpu_ldst_useronly_template.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/exec/cpu_ldst_useronly_template.h b/include/exec/cpu_ldst_useronly_template.h
index 8c7a2c6cd7..d663826ac2 100644
--- a/include/exec/cpu_ldst_useronly_template.h
+++ b/include/exec/cpu_ldst_useronly_template.h
@@ -118,11 +118,9 @@ static inline void
glue(glue(cpu_st, SUFFIX), MEMSUFFIX)(CPUArchState *env, abi_ptr ptr,
RES_TYPE v)
{
-#if !defined(CODE_ACCESS)
trace_guest_mem_before_exec(
env_cpu(env), ptr,
trace_mem_build_info(SHIFT, false, MO_TE, true));
-#endif
glue(glue(st, SUFFIX), _p)(g2h(ptr), v);
}
--
2.17.1
next prev parent reply other threads:[~2019-07-09 16:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 16:36 [Qemu-devel] [PATCH v2 0/5] tcg: Fix mmap_lock assertion failure, take 2 Richard Henderson
2019-07-09 16:36 ` [Qemu-devel] [PATCH v2 1/5] include/qemu/atomic.h: Add signal_barrier Richard Henderson
2019-07-09 16:36 ` [Qemu-devel] [PATCH v2 2/5] tcg: Introduce set/clear_helper_retaddr Richard Henderson
2019-07-09 16:36 ` [Qemu-devel] [PATCH v2 3/5] tcg: Remove cpu_ld*_code_ra Richard Henderson
2019-07-09 16:36 ` Richard Henderson [this message]
2019-07-09 16:36 ` [Qemu-devel] [PATCH v2 5/5] tcg: Release mmap_lock on translation fault Richard Henderson
2019-07-09 20:48 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709163656.3100-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).