qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, linuxram@us.ibm.com, bharata@linux.ibm.com
Subject: Re: [Qemu-devel] [PATCH v0] ppc/spapr: Support reboot of secure pseries guest
Date: Thu, 11 Jul 2019 11:31:16 +1000	[thread overview]
Message-ID: <20190711013116.GD13271@umbus.fritz.box> (raw)
In-Reply-To: <156273913241.3386.15746188914180946036@c4a48874b076>

[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]

On Tue, Jul 09, 2019 at 11:12:13PM -0700, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190710060621.16430-1-bharata@linux.ibm.com/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Message-id: 20190710060621.16430-1-bharata@linux.ibm.com
> Type: series
> Subject: [Qemu-devel] [PATCH v0] ppc/spapr: Support reboot of secure pseries guest
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> From https://github.com/patchew-project/qemu
>  * [new tag]               patchew/20190710060621.16430-1-bharata@linux.ibm.com -> patchew/20190710060621.16430-1-bharata@linux.ibm.com
> Switched to a new branch 'test'
> 636a27f80f ppc/spapr: Support reboot of secure pseries guest
> 
> === OUTPUT BEGIN ===
> ERROR: code indent should never use tabs
> #79: FILE: target/ppc/kvm_ppc.h:207:
> +^Ireturn 0;$

Ah, yeah, fix this too, please.

> total: 1 errors, 0 warnings, 42 lines checked
> 
> Commit 636a27f80f0d (ppc/spapr: Support reboot of secure pseries guest) has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/20190710060621.16430-1-bharata@linux.ibm.com/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-07-11  2:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10  6:06 [Qemu-devel] [PATCH v0] ppc/spapr: Support reboot of secure pseries guest Bharata B Rao
2019-07-10  6:12 ` no-reply
2019-07-11  1:31   ` David Gibson [this message]
2019-07-11  1:31 ` David Gibson
2019-07-11  3:08   ` Bharata B Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190711013116.GD13271@umbus.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=bharata@linux.ibm.com \
    --cc=linuxram@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).