From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8203FC742A2 for ; Fri, 12 Jul 2019 02:29:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 583B221019 for ; Fri, 12 Jul 2019 02:29:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 583B221019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hllJh-0004g7-GV for qemu-devel@archiver.kernel.org; Thu, 11 Jul 2019 22:29:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43292) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hllJX-0004HB-EK for qemu-devel@nongnu.org; Thu, 11 Jul 2019 22:29:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hllJV-0006jh-T5 for qemu-devel@nongnu.org; Thu, 11 Jul 2019 22:29:35 -0400 Received: from mga03.intel.com ([134.134.136.65]:13144) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hllJV-0006jF-KC for qemu-devel@nongnu.org; Thu, 11 Jul 2019 22:29:33 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2019 19:29:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,480,1557212400"; d="scan'208";a="341570683" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga005.jf.intel.com with ESMTP; 11 Jul 2019 19:29:30 -0700 Date: Fri, 12 Jul 2019 10:29:03 +0800 From: Wei Yang To: "Dr. David Alan Gilbert" Message-ID: <20190712022903.GA3684@richard> References: <20190703011234.20517-1-richardw.yang@linux.intel.com> <20190711093427.GE3971@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190711093427.GE3971@work-vm> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 Subject: Re: [Qemu-devel] [PATCH] migration/postcopy: fix document of postcopy_send_discard_bm_ram() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: quintela@redhat.com, Wei Yang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 11, 2019 at 10:34:27AM +0100, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.yang@linux.intel.com) wrote: >> Commit 6b6712efccd3 ('ram: Split dirty bitmap by RAMBlock') changes the >> parameter of postcopy_send_discard_bm_ram(), while left the document >> part untouched. >> >> This patch correct the document and fix one typo by hand. >> >> Signed-off-by: Wei Yang >> --- >> migration/ram.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/migration/ram.c b/migration/ram.c >> index 246efe6939..410e0f89fe 100644 >> --- a/migration/ram.c >> +++ b/migration/ram.c >> @@ -2763,8 +2763,7 @@ void ram_postcopy_migrated_memory_release(MigrationState *ms) >> * >> * @ms: current migration state >> * @pds: state for postcopy >> - * @start: RAMBlock starting page >> - * @length: RAMBlock size >> + * @block: RAMBlock to discard >> */ >> static int postcopy_send_discard_bm_ram(MigrationState *ms, >> PostcopyDiscardState *pds, >> @@ -2961,7 +2960,7 @@ static void postcopy_chunk_hostpages_pass(MigrationState *ms, bool unsent_pass, >> } >> >> /** >> - * postcopy_chuck_hostpages: discrad any partially sent host page >> + * postcopy_chuck_hostpages: discard any partially sent host page > >While we're here we should probably fix the name of the function as >well! s/chuck/chunk/ > Ah, didn't notice this :) Do you like me to send v2 to fix this? >Dave > >> * >> * Utility for the outgoing postcopy code. >> * >> -- >> 2.19.1 >> >-- >Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK -- Wei Yang Help you, Help me