Re: [Qemu-devel] [PATCH v2] migration/postcopy: fix document of postcopy_send_discard_bm_ram()

[Wei Yang <richardw.yang@linux.intel.com>]

On Mon, Jul 15, 2019 at 10:05:49AM +0800, Wei Yang wrote:
>Commit 6b6712efccd3 ('ram: Split dirty bitmap by RAMBlock') changes the
>parameter of postcopy_send_discard_bm_ram(), while left the document
>part untouched.
>
>This patch correct the document and fix two typo by hand.
>
>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>

Oops, I missed this. Sorry Philippe :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>---
>v2: fix typo in function name, pointed by Dave
>---
> migration/ram.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/migration/ram.c b/migration/ram.c
>index 246efe6939..e019c925b2 100644
>--- a/migration/ram.c
>+++ b/migration/ram.c
>@@ -2763,8 +2763,7 @@ void ram_postcopy_migrated_memory_release(MigrationState *ms)
>  *
>  * @ms: current migration state
>  * @pds: state for postcopy
>- * @start: RAMBlock starting page
>- * @length: RAMBlock size
>+ * @block: RAMBlock to discard
>  */
> static int postcopy_send_discard_bm_ram(MigrationState *ms,
>                                         PostcopyDiscardState *pds,
>@@ -2961,7 +2960,7 @@ static void postcopy_chunk_hostpages_pass(MigrationState *ms, bool unsent_pass,
> }
> 
> /**
>- * postcopy_chuck_hostpages: discrad any partially sent host page
>+ * postcopy_chunk_hostpages: discard any partially sent host page
>  *
>  * Utility for the outgoing postcopy code.
>  *
>-- 
>2.17.1

-- 
Wei Yang
Help you, Help me