* [Qemu-devel] [PATCH] rdmacm-mux: fix strcpy string warning
@ 2019-07-12 16:51 Marc-André Lureau
2019-07-12 17:33 ` Paolo Bonzini
2019-07-15 13:14 ` Yuval Shaia
0 siblings, 2 replies; 3+ messages in thread
From: Marc-André Lureau @ 2019-07-12 16:51 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Yuval Shaia, Marc-André Lureau
../contrib/rdmacm-mux/main.c: In function ‘parse_args’:
../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835 equals destination size [-Werror=stringop-truncation]
118 | strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
contrib/rdmacm-mux/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c
index 30c7052651..de53048f06 100644
--- a/contrib/rdmacm-mux/main.c
+++ b/contrib/rdmacm-mux/main.c
@@ -115,7 +115,7 @@ static void parse_args(int argc, char *argv[])
case 's':
/* This is temporary, final name will build below */
- strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
+ strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX - 1);
break;
case 'p':
--
2.22.0.428.g6d5b264208
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] rdmacm-mux: fix strcpy string warning
2019-07-12 16:51 [Qemu-devel] [PATCH] rdmacm-mux: fix strcpy string warning Marc-André Lureau
@ 2019-07-12 17:33 ` Paolo Bonzini
2019-07-15 13:14 ` Yuval Shaia
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2019-07-12 17:33 UTC (permalink / raw)
To: Marc-André Lureau, qemu-devel; +Cc: Yuval Shaia
On 12/07/19 18:51, Marc-André Lureau wrote:
> ../contrib/rdmacm-mux/main.c: In function ‘parse_args’:
> ../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835 equals destination size [-Werror=stringop-truncation]
> 118 | strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> contrib/rdmacm-mux/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c
> index 30c7052651..de53048f06 100644
> --- a/contrib/rdmacm-mux/main.c
> +++ b/contrib/rdmacm-mux/main.c
> @@ -115,7 +115,7 @@ static void parse_args(int argc, char *argv[])
>
> case 's':
> /* This is temporary, final name will build below */
> - strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
> + strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX - 1);
> break;
>
> case 'p':
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] rdmacm-mux: fix strcpy string warning
2019-07-12 16:51 [Qemu-devel] [PATCH] rdmacm-mux: fix strcpy string warning Marc-André Lureau
2019-07-12 17:33 ` Paolo Bonzini
@ 2019-07-15 13:14 ` Yuval Shaia
1 sibling, 0 replies; 3+ messages in thread
From: Yuval Shaia @ 2019-07-15 13:14 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: pbonzini, qemu-devel
On Fri, Jul 12, 2019 at 08:51:54PM +0400, Marc-André Lureau wrote:
> ../contrib/rdmacm-mux/main.c: In function ‘parse_args’:
> ../contrib/rdmacm-mux/main.c:118:13: error: ‘strncpy’ specified bound 3835 equals destination size [-Werror=stringop-truncation]
> 118 | strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> contrib/rdmacm-mux/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/rdmacm-mux/main.c b/contrib/rdmacm-mux/main.c
> index 30c7052651..de53048f06 100644
> --- a/contrib/rdmacm-mux/main.c
> +++ b/contrib/rdmacm-mux/main.c
> @@ -115,7 +115,7 @@ static void parse_args(int argc, char *argv[])
>
> case 's':
> /* This is temporary, final name will build below */
> - strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX);
> + strncpy(unix_socket_path, optarg, SOCKET_PATH_MAX - 1);
Oops,
Thanks!
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> break;
>
> case 'p':
> --
> 2.22.0.428.g6d5b264208
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-15 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-12 16:51 [Qemu-devel] [PATCH] rdmacm-mux: fix strcpy string warning Marc-André Lureau
2019-07-12 17:33 ` Paolo Bonzini
2019-07-15 13:14 ` Yuval Shaia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).