From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PULL 03/11] block/stream: Fix error path
Date: Mon, 15 Jul 2019 16:28:57 +0200 [thread overview]
Message-ID: <20190715142905.9078-4-mreitz@redhat.com> (raw)
In-Reply-To: <20190715142905.9078-1-mreitz@redhat.com>
As of commit c624b015bf14fe01f1e6452a36e63b3ea1ae4998, the stream job
only freezes the chain until the overlay of the base node. The error
path must consider this.
Fixes: c624b015bf14fe01f1e6452a36e63b3ea1ae4998
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20190703172813.6868-3-mreitz@redhat.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/stream.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/stream.c b/block/stream.c
index cd5e2ba9b0..b27e61625d 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -284,5 +284,5 @@ fail:
if (bs_read_only) {
bdrv_reopen_set_read_only(bs, true, NULL);
}
- bdrv_unfreeze_backing_chain(bs, base);
+ bdrv_unfreeze_backing_chain(bs, bottom);
}
--
2.21.0
next prev parent reply other threads:[~2019-07-15 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:28 [Qemu-devel] [PULL 00/11] Block patches for rc1 Max Reitz
2019-07-15 14:28 ` [Qemu-devel] [PULL 01/11] nvme: Set number of queues later in nvme_init() Max Reitz
2019-07-15 14:28 ` [Qemu-devel] [PULL 02/11] block: Add BDS.never_freeze Max Reitz
2019-07-15 14:28 ` Max Reitz [this message]
2019-07-15 14:28 ` [Qemu-devel] [PULL 04/11] block/stream: Swap backing file change order Max Reitz
2019-07-15 14:28 ` [Qemu-devel] [PULL 05/11] block: Deep-clear inherits_from Max Reitz
2019-07-15 14:29 ` [Qemu-devel] [PULL 06/11] iotests: Fix throttling in 030 Max Reitz
2019-07-15 14:29 ` [Qemu-devel] [PULL 07/11] iotests: Compare error messages " Max Reitz
2019-07-15 14:29 ` [Qemu-devel] [PULL 08/11] iotests: Add @use_log to VM.run_job() Max Reitz
2019-07-15 14:29 ` [Qemu-devel] [PULL 09/11] iotests: Add new case to 030 Max Reitz
2019-07-15 14:29 ` [Qemu-devel] [PULL 10/11] iotests: Add read-only test " Max Reitz
2019-07-15 14:29 ` [Qemu-devel] [PULL 11/11] gluster: fix .bdrv_reopen_prepare when backing file is a JSON object Max Reitz
2019-07-15 15:56 ` [Qemu-devel] [PULL 00/11] Block patches for rc1 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715142905.9078-4-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).