From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Aleksandar Rikalo" <arikalo@wavecomp.com>,
"James Hogan" <jhogan@kernel.org>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-arm@nongnu.org,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"James Hogan" <james.hogan@mips.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [Qemu-devel] [RFC PATCH-for-4.1? v2 0/5] semihosting: Build with CONFIG_SEMIHOSTING disabled
Date: Mon, 15 Jul 2019 17:22:20 +0200 [thread overview]
Message-ID: <20190715152225.26135-1-philmd@redhat.com> (raw)
Amusingly Miroslav and myself hit this issue at the same time.
Note now that "config-devices.h" exists (commit 6c22ea9d83) I could use
#include "config-devices.h" to implement Alex's suggestion to avoid a stub:
https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg03607.html
Some know (arch-specific) limitations are:
- MIPS ITU is accessed by coprocessor instr (ISA feature)
- MIPS timer is accessed by coprocessor instr (ISA feature)
- MIPS semihosting (ISA feature?)
- ARM semihosting (ISA feature?)
- ARMv7 NVIC (device)
This series attempt to fix this the most trivial way, adding
stubs for unreachable code.
Since v1: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg07267.html
- Always enable semihosting on linux-user
$ git backport-diff -u v1
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only (new)
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/5:[down] 'target/arm: Always enable CONFIG_SEMIHOSTING'
002/5:[down] 'target/mips: Always enable CONFIG_SEMIHOSTING'
003/5:[down] 'hw/semihosting: Allow this feature to be disabled'
004/5:[0004] [FC] 'target/arm: Add stubs to build with CONFIG_SEMIHOSTING disabled'
005/5:[0005] [FC] 'target/mips: Add stubs to build with CONFIG_SEMIHOSTING disabled'
Philippe Mathieu-Daudé (5):
target/arm: Always enable CONFIG_SEMIHOSTING
target/mips: Always enable CONFIG_SEMIHOSTING
hw/semihosting: Allow this feature to be disabled
target/arm: Add stubs to build with CONFIG_SEMIHOSTING disabled
target/mips: Add stubs to build with CONFIG_SEMIHOSTING disabled
default-configs/aarch64-linux-user-common.mak | 4 ++++
default-configs/aarch64-linux-user.mak | 2 ++
default-configs/aarch64_be-linux-user.mak | 2 ++
default-configs/arm-linux-user-common.mak | 4 ++++
default-configs/arm-linux-user.mak | 2 ++
default-configs/arm-softmmu.mak | 4 +++-
default-configs/armeb-linux-user.mak | 2 ++
default-configs/mips-linux-user-common.mak | 4 ++++
default-configs/mips-linux-user.mak | 2 ++
default-configs/mips-softmmu-common.mak | 2 +-
default-configs/mips64-linux-user.mak | 2 ++
default-configs/mips64el-linux-user.mak | 2 ++
default-configs/mipsel-linux-user.mak | 2 ++
default-configs/mipsn32-linux-user.mak | 2 ++
default-configs/mipsn32el-linux-user.mak | 2 ++
hw/semihosting/Kconfig | 3 ++-
target/arm/Makefile.objs | 3 ++-
target/arm/arm-semi-stubs.c | 21 ++++++++++++++++++
target/mips/Makefile.objs | 3 ++-
target/mips/mips-semi-stubs.c | 22 +++++++++++++++++++
20 files changed, 85 insertions(+), 5 deletions(-)
create mode 100644 default-configs/aarch64-linux-user-common.mak
create mode 100644 default-configs/arm-linux-user-common.mak
create mode 100644 default-configs/mips-linux-user-common.mak
create mode 100644 target/arm/arm-semi-stubs.c
create mode 100644 target/mips/mips-semi-stubs.c
--
2.20.1
next reply other threads:[~2019-07-15 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 15:22 Philippe Mathieu-Daudé [this message]
2019-07-15 15:22 ` [Qemu-devel] [RFC PATCH-for-4.1? v2 1/5] target/arm: Always enable CONFIG_SEMIHOSTING Philippe Mathieu-Daudé
2019-07-15 15:22 ` [Qemu-devel] [RFC PATCH-for-4.1? v2 2/5] target/mips: " Philippe Mathieu-Daudé
2019-07-15 15:22 ` [Qemu-devel] [RFC PATCH-for-4.1? v2 3/5] hw/semihosting: Allow this feature to be disabled Philippe Mathieu-Daudé
2019-07-15 15:22 ` [Qemu-devel] [RFC PATCH-for-4.1? v2 4/5] target/arm: Add stubs to build with CONFIG_SEMIHOSTING disabled Philippe Mathieu-Daudé
2019-07-15 15:22 ` [Qemu-devel] [RFC PATCH-for-4.1? v2 5/5] target/mips: " Philippe Mathieu-Daudé
2019-07-15 21:09 ` [Qemu-devel] [RFC PATCH-for-4.1? v2 0/5] semihosting: Build " no-reply
2019-07-16 9:30 ` Philippe Mathieu-Daudé
2019-07-16 14:14 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715152225.26135-1-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=amarkovic@wavecomp.com \
--cc=arikalo@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=james.hogan@mips.com \
--cc=jhogan@kernel.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).