From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: consolidate time info into populate_time_info
Date: Tue, 16 Jul 2019 10:59:30 +0100 [thread overview]
Message-ID: <20190716095930.GA2770@work-vm> (raw)
In-Reply-To: <20190716005411.4156-1-richardw.yang@linux.intel.com>
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> Consolidate time information fill up into its function for better
> readability.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/migration.c | 40 ++++++++++++++++++++++------------------
> 1 file changed, 22 insertions(+), 18 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 47fe22d327..18ef933105 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -822,6 +822,25 @@ bool migration_is_setup_or_active(int state)
> }
> }
>
> +static void populate_time_info(MigrationInfo *info, MigrationState *s)
> +{
> + info->has_status = true;
> + info->has_setup_time = true;
> + info->setup_time = s->setup_time;
> + if (s->state == MIGRATION_STATUS_COMPLETED) {
> + info->has_total_time = true;
> + info->total_time = s->total_time;
> + info->has_downtime = true;
> + info->downtime = s->downtime;
> + } else {
> + info->has_total_time = true;
> + info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME) -
> + s->start_time;
> + info->has_expected_downtime = true;
> + info->expected_downtime = s->expected_downtime;
> + }
> +}
> +
> static void populate_ram_info(MigrationInfo *info, MigrationState *s)
> {
> info->has_ram = true;
> @@ -907,16 +926,8 @@ static void fill_source_migration_info(MigrationInfo *info)
> case MIGRATION_STATUS_DEVICE:
> case MIGRATION_STATUS_POSTCOPY_PAUSED:
> case MIGRATION_STATUS_POSTCOPY_RECOVER:
> - /* TODO add some postcopy stats */
> - info->has_status = true;
> - info->has_total_time = true;
> - info->total_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME)
> - - s->start_time;
> - info->has_expected_downtime = true;
> - info->expected_downtime = s->expected_downtime;
> - info->has_setup_time = true;
> - info->setup_time = s->setup_time;
> -
> + /* TODO add some postcopy stats */
> + populate_time_info(info, s);
> populate_ram_info(info, s);
> populate_disk_info(info);
> break;
> @@ -925,14 +936,7 @@ static void fill_source_migration_info(MigrationInfo *info)
> /* TODO: display COLO specific information (checkpoint info etc.) */
> break;
> case MIGRATION_STATUS_COMPLETED:
> - info->has_status = true;
> - info->has_total_time = true;
> - info->total_time = s->total_time;
> - info->has_downtime = true;
> - info->downtime = s->downtime;
> - info->has_setup_time = true;
> - info->setup_time = s->setup_time;
> -
> + populate_time_info(info, s);
> populate_ram_info(info, s);
> break;
> case MIGRATION_STATUS_FAILED:
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-07-16 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 0:54 [Qemu-devel] [PATCH] migration: consolidate time info into populate_time_info Wei Yang
2019-07-16 9:59 ` Dr. David Alan Gilbert [this message]
2019-08-07 17:13 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716095930.GA2770@work-vm \
--to=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).