* [Qemu-devel] Fixing Snowridge CPU model name and features
@ 2019-07-16 15:58 Paul Lai
2019-07-29 15:22 ` Bruce Rogers
0 siblings, 1 reply; 4+ messages in thread
From: Paul Lai @ 2019-07-16 15:58 UTC (permalink / raw)
To: qemu-devel; +Cc: wei.w.wang, luwei.kang, tao3.xu, paul.c.lai
Changing the name to Snowridge from SnowRidge-Server.
There is no client model of Snowridge, so "-Server" is unnecessary.
Removing CPUID_EXT_VMX from Snowridge cpu feature list.
Signed-off-by: Paul Lai <paul.c.lai@intel.com>
Tested-by: Tao3 Xu <tao3.xu@intel.com>
---
target/i386/cpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 63d89276fe..7f56e887ae 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -2688,7 +2688,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
.model_id = "Intel Xeon Processor (Icelake)",
},
{
- .name = "SnowRidge-Server",
+ .name = "Snowridge",
.level = 27,
.vendor = CPUID_VENDOR_INTEL,
.family = 6,
@@ -2706,7 +2706,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
CPUID_FXSR | CPUID_SSE | CPUID_SSE2,
.features[FEAT_1_ECX] =
CPUID_EXT_SSE3 | CPUID_EXT_PCLMULQDQ | CPUID_EXT_MONITOR |
- CPUID_EXT_VMX |
CPUID_EXT_SSSE3 |
CPUID_EXT_CX16 |
CPUID_EXT_SSE41 |
--
2.17.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] Fixing Snowridge CPU model name and features
2019-07-16 15:58 [Qemu-devel] Fixing Snowridge CPU model name and features Paul Lai
@ 2019-07-29 15:22 ` Bruce Rogers
2019-07-29 15:46 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Rogers @ 2019-07-29 15:22 UTC (permalink / raw)
To: ehabkost@redhat.com, paul.c.lai@intel.com,
peter.maydell@linaro.org, qemu-devel@nongnu.org
Cc: tao3.xu@intel.com, luwei.kang@intel.com, wei.w.wang@intel.com
On Tue, 2019-07-16 at 08:58 -0700, Paul Lai wrote:
> Changing the name to Snowridge from SnowRidge-Server.
> There is no client model of Snowridge, so "-Server" is unnecessary.
>
> Removing CPUID_EXT_VMX from Snowridge cpu feature list.
>
> Signed-off-by: Paul Lai <paul.c.lai@intel.com>
> Tested-by: Tao3 Xu <tao3.xu@intel.com>
> ---
> target/i386/cpu.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 63d89276fe..7f56e887ae 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -2688,7 +2688,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
> .model_id = "Intel Xeon Processor (Icelake)",
> },
> {
> - .name = "SnowRidge-Server",
> + .name = "Snowridge",
> .level = 27,
> .vendor = CPUID_VENDOR_INTEL,
> .family = 6,
> @@ -2706,7 +2706,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
> CPUID_FXSR | CPUID_SSE | CPUID_SSE2,
> .features[FEAT_1_ECX] =
> CPUID_EXT_SSE3 | CPUID_EXT_PCLMULQDQ | CPUID_EXT_MONITOR
> |
> - CPUID_EXT_VMX |
> CPUID_EXT_SSSE3 |
> CPUID_EXT_CX16 |
> CPUID_EXT_SSE41 |
What is the status of this patch with respect to the v4.1.0 release?
It would seem to me that it was targeted for this release, to get the
name and features right before codified in a released version, but
Intel would know better.
Bruce
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] Fixing Snowridge CPU model name and features
2019-07-29 15:22 ` Bruce Rogers
@ 2019-07-29 15:46 ` Peter Maydell
2019-07-29 16:04 ` Eduardo Habkost
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2019-07-29 15:46 UTC (permalink / raw)
To: Bruce Rogers
Cc: luwei.kang@intel.com, ehabkost@redhat.com, paul.c.lai@intel.com,
qemu-devel@nongnu.org, wei.w.wang@intel.com, Paolo Bonzini,
tao3.xu@intel.com, Richard Henderson
On Mon, 29 Jul 2019 at 16:42, Bruce Rogers <BROGERS@suse.com> wrote:
>
> On Tue, 2019-07-16 at 08:58 -0700, Paul Lai wrote:
> > Changing the name to Snowridge from SnowRidge-Server.
> > There is no client model of Snowridge, so "-Server" is unnecessary.
> >
> > Removing CPUID_EXT_VMX from Snowridge cpu feature list.
> >
> > Signed-off-by: Paul Lai <paul.c.lai@intel.com>
> > Tested-by: Tao3 Xu <tao3.xu@intel.com>
> > ---
> > target/i386/cpu.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 63d89276fe..7f56e887ae 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -2688,7 +2688,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
> > .model_id = "Intel Xeon Processor (Icelake)",
> > },
> > {
> > - .name = "SnowRidge-Server",
> > + .name = "Snowridge",
> > .level = 27,
> > .vendor = CPUID_VENDOR_INTEL,
> > .family = 6,
> > @@ -2706,7 +2706,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
> > CPUID_FXSR | CPUID_SSE | CPUID_SSE2,
> > .features[FEAT_1_ECX] =
> > CPUID_EXT_SSE3 | CPUID_EXT_PCLMULQDQ | CPUID_EXT_MONITOR
> > |
> > - CPUID_EXT_VMX |
> > CPUID_EXT_SSSE3 |
> > CPUID_EXT_CX16 |
> > CPUID_EXT_SSE41 |
>
> What is the status of this patch with respect to the v4.1.0 release?
> It would seem to me that it was targeted for this release, to get the
> name and features right before codified in a released version, but
> Intel would know better.
If nobody picks it up this afternoon then it has (probably) missed the boat.
Not ccing any of the target/i386 maintainers or putting "for-4.1"
in the subject line is probably why it got missed. Eduardo/Paolo/Richard ?
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] Fixing Snowridge CPU model name and features
2019-07-29 15:46 ` Peter Maydell
@ 2019-07-29 16:04 ` Eduardo Habkost
0 siblings, 0 replies; 4+ messages in thread
From: Eduardo Habkost @ 2019-07-29 16:04 UTC (permalink / raw)
To: Peter Maydell
Cc: luwei.kang@intel.com, paul.c.lai@intel.com, qemu-devel@nongnu.org,
Bruce Rogers, wei.w.wang@intel.com, Paolo Bonzini,
tao3.xu@intel.com, Richard Henderson
On Mon, Jul 29, 2019 at 04:46:01PM +0100, Peter Maydell wrote:
> On Mon, 29 Jul 2019 at 16:42, Bruce Rogers <BROGERS@suse.com> wrote:
> >
> > On Tue, 2019-07-16 at 08:58 -0700, Paul Lai wrote:
> > > Changing the name to Snowridge from SnowRidge-Server.
> > > There is no client model of Snowridge, so "-Server" is unnecessary.
> > >
> > > Removing CPUID_EXT_VMX from Snowridge cpu feature list.
> > >
> > > Signed-off-by: Paul Lai <paul.c.lai@intel.com>
> > > Tested-by: Tao3 Xu <tao3.xu@intel.com>
> > > ---
> > > target/i386/cpu.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > > index 63d89276fe..7f56e887ae 100644
> > > --- a/target/i386/cpu.c
> > > +++ b/target/i386/cpu.c
> > > @@ -2688,7 +2688,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
> > > .model_id = "Intel Xeon Processor (Icelake)",
> > > },
> > > {
> > > - .name = "SnowRidge-Server",
> > > + .name = "Snowridge",
> > > .level = 27,
> > > .vendor = CPUID_VENDOR_INTEL,
> > > .family = 6,
> > > @@ -2706,7 +2706,6 @@ static X86CPUDefinition builtin_x86_defs[] = {
> > > CPUID_FXSR | CPUID_SSE | CPUID_SSE2,
> > > .features[FEAT_1_ECX] =
> > > CPUID_EXT_SSE3 | CPUID_EXT_PCLMULQDQ | CPUID_EXT_MONITOR
> > > |
> > > - CPUID_EXT_VMX |
> > > CPUID_EXT_SSSE3 |
> > > CPUID_EXT_CX16 |
> > > CPUID_EXT_SSE41 |
> >
> > What is the status of this patch with respect to the v4.1.0 release?
> > It would seem to me that it was targeted for this release, to get the
> > name and features right before codified in a released version, but
> > Intel would know better.
>
> If nobody picks it up this afternoon then it has (probably) missed the boat.
> Not ccing any of the target/i386 maintainers or putting "for-4.1"
> in the subject line is probably why it got missed. Eduardo/Paolo/Richard ?
I'll pick it and send a pull request ASAP.
--
Eduardo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-29 16:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-16 15:58 [Qemu-devel] Fixing Snowridge CPU model name and features Paul Lai
2019-07-29 15:22 ` Bruce Rogers
2019-07-29 15:46 ` Peter Maydell
2019-07-29 16:04 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).