From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C91C7618F for ; Tue, 16 Jul 2019 15:27:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BEC682173E for ; Tue, 16 Jul 2019 15:27:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BEC682173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50122 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnPM9-0001KT-2r for qemu-devel@archiver.kernel.org; Tue, 16 Jul 2019 11:27:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60092) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnPLj-0007xi-1r for qemu-devel@nongnu.org; Tue, 16 Jul 2019 11:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnPLh-0003b8-W3 for qemu-devel@nongnu.org; Tue, 16 Jul 2019 11:26:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36156) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnPLh-0003ak-Qx; Tue, 16 Jul 2019 11:26:37 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 149563092650; Tue, 16 Jul 2019 15:26:37 +0000 (UTC) Received: from gondolin (ovpn-117-180.ams2.redhat.com [10.36.117.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 591E75B681; Tue, 16 Jul 2019 15:26:29 +0000 (UTC) Date: Tue, 16 Jul 2019 17:26:26 +0200 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Message-ID: <20190716172626.7abc7736.cohuck@redhat.com> In-Reply-To: References: <20190708125433.16927-1-cohuck@redhat.com> <20190708125433.16927-3-cohuck@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 16 Jul 2019 15:26:37 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH for-4.1 2/2] s390x/tcg: move fallthrough annotation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Collin Walling , David Hildenbrand , Stefan Weil , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 16 Jul 2019 17:22:59 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > On 7/8/19 2:54 PM, Cornelia Huck wrote: > > ...so that the compiler properly recognizes it. > >=20 > > Reported-by: Stefan Weil > > Fixes: f180da83c039 ("s390x/tcg: Implement VECTOR LOAD LOGICAL ELEMENT = AND ZERO") > > Signed-off-by: Cornelia Huck > > --- > > target/s390x/translate_vx.inc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/target/s390x/translate_vx.inc.c b/target/s390x/translate_v= x.inc.c > > index 7b1d31cba5cf..41d5cf869f94 100644 > > --- a/target/s390x/translate_vx.inc.c > > +++ b/target/s390x/translate_vx.inc.c > > @@ -577,8 +577,8 @@ static DisasJumpType op_vllez(DisasContext *s, Disa= sOps *o) > > enr =3D 0; > > break; > > } > > - default: > > /* fallthrough */ > > + default: =20 >=20 > Haha :) >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 Thanks, but this is already merged :) >=20 > > gen_program_exception(s, PGM_SPECIFICATION); > > return DISAS_NORETURN; > > } > > =20