From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8CCC7618F for ; Tue, 16 Jul 2019 22:16:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E81A2173B for ; Tue, 16 Jul 2019 22:16:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E81A2173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnVkG-00060V-Ne for qemu-devel@archiver.kernel.org; Tue, 16 Jul 2019 18:16:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41479) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnVk4-0005Xe-PS for qemu-devel@nongnu.org; Tue, 16 Jul 2019 18:16:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnVk3-0002Cc-Kk for qemu-devel@nongnu.org; Tue, 16 Jul 2019 18:16:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41202) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnVk1-00029y-4I; Tue, 16 Jul 2019 18:16:09 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1BAFF368E3; Tue, 16 Jul 2019 22:16:08 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-58.brq.redhat.com [10.40.204.58]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CCB305E7A5; Tue, 16 Jul 2019 22:15:58 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Date: Wed, 17 Jul 2019 00:15:50 +0200 Message-Id: <20190716221555.11145-1-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 16 Jul 2019 22:16:08 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH-for-4.1 v6 0/5] hw/block/pflash_cfi01: Add DeviceReset() handler X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Laszlo Ersek , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Markus Armbruster , Max Reitz , Alistair Francis , John Snow , "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hello it's me again, insisting with this series because there are at least 2 different report of guests bricked on reset due to the bug fixed by patch #5: https://bugzilla.redhat.com/show_bug.cgi?id=3D1678713 https://bugzilla.redhat.com/show_bug.cgi?id=3D1704584 Patches missing review: 2 and 3 The pflash device lacks a reset() function. When a machine is resetted, the flash might be in an inconsistent state, leading to unexpected behavior. Resolve this issue by adding a DeviceReset() handler. Since v1: https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg00962.= html - addressed Laszlo review comments Since v2: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg00395.= html - consider migration (Laszlo, Peter) Since v3: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01668.= html - more reliable migration (Dave) - dropped patches 6-9 not required for next release Since v4: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg02785.= html - document why using READ_ARRAY value 0x00 for migration is safe Since v5: https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg03366.= html - avoid trying to be spec-compliant and messing with migration. KISS. review/test tags reset, sorry. $ git backport-diff -u v5 Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream pat= ch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respec= tively 001/5:[----] [-C] 'hw/block/pflash_cfi01: Removed an unused timer' 002/5:[down] 'hw/block/pflash_cfi01: Document use of non-CFI compliant co= mmand '0x00'' 003/5:[0031] [FC] 'hw/block/pflash_cfi01: Extract pflash_mode_read_array(= )' 004/5:[down] 'hw/block/pflash_cfi01: Rename 'reset_flash' label as 'mode_= read_array'' 005/5:[----] [--] 'hw/block/pflash_cfi01: Add the DeviceReset() handler' Regards, Phil. Philippe Mathieu-Daud=C3=A9 (5): hw/block/pflash_cfi01: Removed an unused timer hw/block/pflash_cfi01: Document use of non-CFI compliant command '0x00' hw/block/pflash_cfi01: Extract pflash_mode_read_array() hw/block/pflash_cfi01: Rename 'reset_flash' label as 'mode_read_array' hw/block/pflash_cfi01: Add the DeviceReset() handler hw/block/pflash_cfi01.c | 77 +++++++++++++++++++++-------------------- hw/block/trace-events | 1 + 2 files changed, 41 insertions(+), 37 deletions(-) --=20 2.20.1