From: Wei Yang <richardw.yang@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: quintela@redhat.com, Wei Yang <richardw.yang@linux.intel.com>,
dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] ram: RAMBlock->offset is always aligned to a word
Date: Thu, 18 Jul 2019 09:11:20 +0800 [thread overview]
Message-ID: <20190718011120.GB15881@richard> (raw)
In-Reply-To: <dd14052c-b3ed-88b0-b7f4-69dae2a7a660@redhat.com>
On Wed, Jul 17, 2019 at 11:17:50AM +0200, Paolo Bonzini wrote:
>On 30/04/19 05:44, Wei Yang wrote:
>> RAMBlock->offset is calculated by find_ram_offset, which makes sure the
>> offset is aligned to a word.
>>
>> This patch removes the alignment check on offset and unnecessary
>> variable *word*.
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>
>I would add an assertion instead, but overall leaving the condition
>there is harmless. You still need the "else" part for the case where
>the length is unaligned.
>
Thanks, then I would leave current code untouched.
>Paolo
>
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-07-18 1:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 3:44 [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-04-30 3:44 ` [Qemu-devel] [PATCH 1/3] migration/ram.c: start of migration_bitmap_sync_range is always 0 Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-05-14 14:15 ` Dr. David Alan Gilbert
2019-05-14 14:27 ` Dr. David Alan Gilbert
2019-05-15 6:41 ` Wei Yang
2019-05-15 8:04 ` Dr. David Alan Gilbert
2019-05-15 8:54 ` Wei Yang
2019-04-30 3:44 ` [Qemu-devel] [PATCH 2/3] migration/ram.c: start of cpu_physical_memory_sync_dirty_bitmap " Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-05-14 14:21 ` Dr. David Alan Gilbert
2019-05-31 0:54 ` Wei Yang
2019-06-21 7:43 ` Wei Yang
2019-07-17 1:13 ` Wei Yang
2019-07-17 9:16 ` Paolo Bonzini
2019-07-18 1:07 ` Wei Yang
2019-04-30 3:44 ` [Qemu-devel] [PATCH 3/3] ram: RAMBlock->offset is always aligned to a word Wei Yang
2019-04-30 3:44 ` Wei Yang
2019-07-17 9:17 ` Paolo Bonzini
2019-07-18 1:11 ` Wei Yang [this message]
2019-05-01 22:53 ` [Qemu-devel] [PATCH 0/3] Cleanup migration/ram.c no-reply
2019-05-01 22:53 ` no-reply
2019-05-02 0:10 ` Wei Yang
2019-05-02 0:10 ` Wei Yang
2019-05-02 4:24 ` no-reply
2019-05-02 4:24 ` no-reply
2019-05-02 5:32 ` Wei Yang
2019-05-02 5:32 ` Wei Yang
2019-05-02 8:35 ` Dr. David Alan Gilbert
2019-05-02 8:35 ` Dr. David Alan Gilbert
2019-05-02 22:34 ` Wei Yang
2019-05-02 22:34 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718011120.GB15881@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).