From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2071BC7618F for ; Thu, 18 Jul 2019 01:12:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3B5421783 for ; Thu, 18 Jul 2019 01:11:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3B5421783 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnuxj-0002S2-5H for qemu-devel@archiver.kernel.org; Wed, 17 Jul 2019 21:11:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53434) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hnuxZ-000233-9S for qemu-devel@nongnu.org; Wed, 17 Jul 2019 21:11:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hnuxY-0008IQ-D9 for qemu-devel@nongnu.org; Wed, 17 Jul 2019 21:11:49 -0400 Received: from mga04.intel.com ([192.55.52.120]:23296) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hnuxY-0008HJ-55 for qemu-devel@nongnu.org; Wed, 17 Jul 2019 21:11:48 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 18:11:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,276,1559545200"; d="scan'208";a="319490837" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga004.jf.intel.com with ESMTP; 17 Jul 2019 18:11:44 -0700 Date: Thu, 18 Jul 2019 09:11:20 +0800 From: Wei Yang To: Paolo Bonzini Message-ID: <20190718011120.GB15881@richard> References: <20190430034412.12935-1-richardw.yang@linux.intel.com> <20190430034412.12935-4-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.120 Subject: Re: [Qemu-devel] [PATCH 3/3] ram: RAMBlock->offset is always aligned to a word X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: quintela@redhat.com, Wei Yang , dgilbert@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jul 17, 2019 at 11:17:50AM +0200, Paolo Bonzini wrote: >On 30/04/19 05:44, Wei Yang wrote: >> RAMBlock->offset is calculated by find_ram_offset, which makes sure the >> offset is aligned to a word. >> >> This patch removes the alignment check on offset and unnecessary >> variable *word*. >> >> Signed-off-by: Wei Yang > >I would add an assertion instead, but overall leaving the condition >there is harmless. You still need the "else" part for the case where >the length is unaligned. > Thanks, then I would leave current code untouched. >Paolo > -- Wei Yang Help you, Help me