From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF1DC76191 for ; Thu, 18 Jul 2019 08:44:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72273208C0 for ; Thu, 18 Jul 2019 08:44:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72273208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho21Q-0007Yx-ND for qemu-devel@archiver.kernel.org; Thu, 18 Jul 2019 04:44:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56644) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1ho21G-00070O-6v for qemu-devel@nongnu.org; Thu, 18 Jul 2019 04:44:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ho21F-0000o4-4p for qemu-devel@nongnu.org; Thu, 18 Jul 2019 04:44:06 -0400 Received: from mga05.intel.com ([192.55.52.43]:53855) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ho21D-0000m9-4D for qemu-devel@nongnu.org; Thu, 18 Jul 2019 04:44:04 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 01:44:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,276,1559545200"; d="scan'208";a="179181476" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga002.jf.intel.com with ESMTP; 18 Jul 2019 01:43:59 -0700 Date: Thu, 18 Jul 2019 16:43:35 +0800 From: Wei Yang To: Paolo Bonzini Message-ID: <20190718084335.GA5936@richard> References: <20190718012547.16373-1-richardw.yang@linux.intel.com> <7ea77b75-c4d0-3f98-eedc-6900bb95ffa1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ea77b75-c4d0-3f98-eedc-6900bb95ffa1@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.43 Subject: Re: [Qemu-devel] [PATCH] migration: just pass RAMBlock is enough X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: quintela@redhat.com, Wei Yang , dgilbert@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 18, 2019 at 10:17:19AM +0200, Paolo Bonzini wrote: >On 18/07/19 03:25, Wei Yang wrote: >> RAMBlock->used_length is always passed to migration_bitmap_sync_range(), >> which could be retrieved from RAMBlock. >> >> Suggested-by: Paolo Bonzini >> Signed-off-by: Wei Yang >> --- >> migration/ram.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/migration/ram.c b/migration/ram.c >> index 908517fc2b..0a6070d787 100644 >> --- a/migration/ram.c >> +++ b/migration/ram.c >> @@ -1669,11 +1669,10 @@ static inline bool migration_bitmap_clear_dirty(RAMState *rs, >> return ret; >> } >> >> -static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb, >> - ram_addr_t length) >> +static void migration_bitmap_sync_range(RAMState *rs, RAMBlock *rb) >> { >> rs->migration_dirty_pages += >> - cpu_physical_memory_sync_dirty_bitmap(rb, 0, length, >> + cpu_physical_memory_sync_dirty_bitmap(rb, 0, rb->used_length, >> &rs->num_dirty_pages_period); >> } >> >> @@ -1762,7 +1761,7 @@ static void migration_bitmap_sync(RAMState *rs) >> qemu_mutex_lock(&rs->bitmap_mutex); >> rcu_read_lock(); >> RAMBLOCK_FOREACH_NOT_IGNORED(block) { >> - migration_bitmap_sync_range(rs, block, block->used_length); >> + migration_bitmap_sync_range(rs, block); >> } >> ram_counters.remaining = ram_bytes_remaining(); >> rcu_read_unlock(); >> @@ -4193,7 +4192,7 @@ static void colo_flush_ram_cache(void) >> memory_global_dirty_log_sync(); >> rcu_read_lock(); >> RAMBLOCK_FOREACH_NOT_IGNORED(block) { >> - migration_bitmap_sync_range(ram_state, block, block->used_length); >> + migration_bitmap_sync_range(ram_state, block); >> } >> rcu_read_unlock(); >> >> > >Reviewed-by: Paolo Bonzini > >and in fact we can rename the function to ramblock_sync_dirty_bitmap. Sounds reasonable. Let me improve it. > >Paolo -- Wei Yang Help you, Help me