From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 1/3] qmp: don't emit the RESET event on wakeup
Date: Thu, 18 Jul 2019 20:39:49 +1000 [thread overview]
Message-ID: <20190718103951.10027-2-npiggin@gmail.com> (raw)
In-Reply-To: <20190718103951.10027-1-npiggin@gmail.com>
Commit 1405819637f53 ("qmp: don't emit the RESET event on wakeup from
S3") changed system wakeup to avoid calling qapi_event_send_reset.
Commit 76ed4b18debfe ("s390/ipl: fix ipl with -no-reboot") appears to
have inadvertently broken that logic.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
I'm not quite sure if this patch is correct and haven't tested it, I
found it by inspection. If this patch is incorrect, I will have to
adjust patch 2.
vl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vl.c b/vl.c
index 5089fce6c5..ef3c7ab8b8 100644
--- a/vl.c
+++ b/vl.c
@@ -1550,7 +1550,7 @@ void qemu_system_reset(ShutdownCause reason)
} else {
qemu_devices_reset();
}
- if (reason != SHUTDOWN_CAUSE_SUBSYSTEM_RESET) {
+ if (reason && reason != SHUTDOWN_CAUSE_SUBSYSTEM_RESET) {
qapi_event_send_reset(shutdown_caused_by_guest(reason), reason);
}
cpu_synchronize_all_post_reset();
--
2.20.1
next prev parent reply other threads:[~2019-07-18 10:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 10:39 [Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr Nicholas Piggin
2019-07-18 10:39 ` Nicholas Piggin [this message]
2019-07-18 11:06 ` [Qemu-devel] [PATCH 1/3] qmp: don't emit the RESET event on wakeup Paolo Bonzini
2019-07-18 11:27 ` Christian Borntraeger
2019-07-18 23:24 ` Nicholas Piggin
2019-07-19 7:33 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-07-19 9:19 ` [Qemu-devel] " Cornelia Huck
2019-07-18 10:39 ` [Qemu-devel] [PATCH 2/3] machine: Add wakeup method to MachineClass Nicholas Piggin
2019-07-18 10:39 ` [Qemu-devel] [PATCH 3/3] spapr: Implement ibm,suspend-me Nicholas Piggin
2019-07-18 11:08 ` [Qemu-devel] [PATCH 0/3] Series to implement suspend for ppc/spapr Paolo Bonzini
2019-07-18 23:25 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718103951.10027-2-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).