From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32EFCC76195 for ; Fri, 19 Jul 2019 02:45:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0638221849 for ; Fri, 19 Jul 2019 02:45:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.b="UFNHKWti" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0638221849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoItv-0007Jo-3f for qemu-devel@archiver.kernel.org; Thu, 18 Jul 2019 22:45:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46882) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hoItQ-0005tA-WC for qemu-devel@nongnu.org; Thu, 18 Jul 2019 22:45:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hoItK-0000Br-HR for qemu-devel@nongnu.org; Thu, 18 Jul 2019 22:45:05 -0400 Received: from ozlabs.org ([2401:3900:2:1::2]:52281) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hoItH-0008UN-Rc; Thu, 18 Jul 2019 22:45:02 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 45qb2G0RGNz9s4Y; Fri, 19 Jul 2019 12:44:53 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1563504294; bh=xpE/O2f9HvHURJt6AaJyB5megT3/OTDW2v2i97S+jBE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UFNHKWtikZsVbNg4YZA6ir4rjLh0IDRAGd+JbC9XPPz3McAkjhD7M1Tv7dPJBJq8R 6PuyZjpnpdcVYIwI+AJnMz+7yYvC9U8Ihdz7NO2Nwb8UTX7J9fNIugVHUPIRI+Gp3p W+1cy1KBcRFohb2stfs3gNFwn6FFVE865uCVXa4Y= Date: Fri, 19 Jul 2019 12:27:23 +1000 From: David Gibson To: Nicholas Piggin Message-ID: <20190719022723.GQ8468@umbus.fritz.box> References: <20190718034214.14948-1-npiggin@gmail.com> <20190718034214.14948-2-npiggin@gmail.com> <20190718121322.663cb5ec@bahia.lab.toulouse-stg.fr.ibm.com> <1563491322.dlreynwzv6.astroid@bobo.none> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XG0jWBK27HhJN4nS" Content-Disposition: inline In-Reply-To: <1563491322.dlreynwzv6.astroid@bobo.none> User-Agent: Mutt/1.12.0 (2019-05-25) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 Subject: Re: [Qemu-devel] [PATCH v6 1/4] spapr: Implement dispatch tracking for tcg X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, Greg Kurz , =?iso-8859-1?Q?C=E9dric?= Le Goater Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --XG0jWBK27HhJN4nS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 19, 2019 at 09:12:16AM +1000, Nicholas Piggin wrote: > Greg Kurz's on July 18, 2019 8:13 pm: > > On Thu, 18 Jul 2019 13:42:11 +1000 > > Nicholas Piggin wrote: > >=20 > >> Implement cpu_exec_enter/exit on ppc which calls into new methods of > >> the same name in PPCVirtualHypervisorClass. These are used by spapr > >> to implement the splpar VPA dispatch counter initially. > >>=20 > >> Signed-off-by: Nicholas Piggin > >> --- > >> Changes since v5: > >> - Move 'prod' into next patch. > >> - Use uint32_t type for dispatch counter. > >> - Add guest error message for incorrect dispatch counter. > >> - Conditionally compile away if CONFIG_USER_ONLY > >> - Small cleanups > >>=20 > >> Changes since v4: > >> - Store to VPA on the way out as well. > >> - Increment the dispatch counter directly in the VPA, which means it w= ill > >> migrate with guest memory the same as KVM. > >> - Prod need not be migrated, add a comment. > >>=20 > >> hw/ppc/spapr.c | 52 +++++++++++++++++++++++++++++++++ > >> hw/ppc/spapr_hcall.c | 5 ---- > >> include/hw/ppc/spapr.h | 7 +++++ > >> target/ppc/cpu.h | 4 +++ > >> target/ppc/translate_init.inc.c | 27 +++++++++++++++++ > >> 5 files changed, 90 insertions(+), 5 deletions(-) > >>=20 > >> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > >> index 821f0d4a49..3e5678d467 100644 > >> --- a/hw/ppc/spapr.c > >> +++ b/hw/ppc/spapr.c > >> @@ -4302,6 +4302,54 @@ PowerPCCPU *spapr_find_cpu(int vcpu_id) > >> return NULL; > >> } > >> =20 > >> +#ifndef CONFIG_USER_ONLY > >=20 > > This file is for system emulation only, no need to guard here. > >=20 > > This is minor and rest looks good. > >=20 > > Reviewed-by: Greg Kurz >=20 > Thanks for all the reviews Greg (and others), they made significant=20 > improvements. David I'm not sure how you like to work with merging > patches, but if you can add the Reviewed-by tags and this issue, then > I won't have to resend. I've fixed it up in my tree. >=20 > Or if you prefer I can fix it up and send to you privately to reduce > list spam. >=20 > Thanks, > Nick >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --XG0jWBK27HhJN4nS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAl0xKosACgkQbDjKyiDZ s5IMxxAAngYXHLIz5YDMwXP7dxUeiScK9i7UkccueCTvco78PhH1G349Q045Y/Am WaOuazf96IBBxAZXa17lsYzNALJ5U3GtkVB5Ofd/38yEEVlOohciKVMlALgGeUv3 FYaM06C69CFilOaI9wDK/GEMuc3QxYD/AiE/HbAoGjLenn4ntTR1sP433IISEosU goV95lDbj2ucu+nSG5Qrs1Y3uuVAGtnIY5FqTdcr54sEgRxaB8YCEYLr2Xwqp3Np Si1uuM9KQ0V/xx9mHYq5MsSLBODHUefb7vqVWP9AvHFhW1qg2b+OAoy322w+knPG PeXydjmIanRvNVtYMx5p0xrqv8Lfm8MGts/DrQ5fgwTORjLB/m4VLzFCFA+E6t5f t3YxbLYfN3o2G0wDKxBAcKk8Nb2a5vrNZ8WX+C87km+68hGXVuDbin0zj7D+ZTVS S+Vi3nhC92TZMkAOBiMe9xqX4uyb0XIowVSt8tlg0SOhvnq5m6ZZKQXHhH6Egke9 wObXH1zDcviStJ67VySY3xsh2MUEFKxaU4ejSJQilJUVy/KyXE8mOpNUaFwbug0X vvVOgHH6EUyPpqWTET2Pqt2xTN+tUI67XtNkUxmY6RZhJz7UJUGK2pFi0G2tFBHR yJsgrUAnQRhAcyiz/IwYsRgcZBBjFJXrtZdeNWbcJe+YUVT/RQY= =2sl0 -----END PGP SIGNATURE----- --XG0jWBK27HhJN4nS--