* [Qemu-devel] [PATCH] migration: current_migration is never NULL
@ 2019-06-26 0:42 Wei Yang
2019-07-19 15:10 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Wei Yang @ 2019-06-26 0:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Wei Yang, dgilbert, quintela
migration_object_init() create and assign current_migration, which means
it will never be null until migration_shutdown().
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
migration/migration.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 0fd2364961..43fd8297ef 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1667,10 +1667,6 @@ bool migration_is_idle(void)
{
MigrationState *s = current_migration;
- if (!s) {
- return true;
- }
-
switch (s->state) {
case MIGRATION_STATUS_NONE:
case MIGRATION_STATUS_CANCELLED:
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] migration: current_migration is never NULL
2019-06-26 0:42 [Qemu-devel] [PATCH] migration: current_migration is never NULL Wei Yang
@ 2019-07-19 15:10 ` Dr. David Alan Gilbert
2019-07-20 1:37 ` Wei Yang
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-07-19 15:10 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, quintela
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> migration_object_init() create and assign current_migration, which means
> it will never be null until migration_shutdown().
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> ---
> migration/migration.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 0fd2364961..43fd8297ef 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1667,10 +1667,6 @@ bool migration_is_idle(void)
> {
> MigrationState *s = current_migration;
>
> - if (!s) {
> - return true;
> - }
> -
I'd prefer to keep that because it's used by migrate_add_blocker
and without this check it means we'd only be able to add a blocker
after the migration object init - which is probably fine but we
would have to check all the cases and make sure no one breaks it in
the future; where as this check makes it just work and we don't
need to worry about the order.
Dave
> switch (s->state) {
> case MIGRATION_STATUS_NONE:
> case MIGRATION_STATUS_CANCELLED:
> --
> 2.19.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] migration: current_migration is never NULL
2019-07-19 15:10 ` Dr. David Alan Gilbert
@ 2019-07-20 1:37 ` Wei Yang
0 siblings, 0 replies; 3+ messages in thread
From: Wei Yang @ 2019-07-20 1:37 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: quintela, Wei Yang, qemu-devel
On Fri, Jul 19, 2019 at 04:10:02PM +0100, Dr. David Alan Gilbert wrote:
>* Wei Yang (richardw.yang@linux.intel.com) wrote:
>> migration_object_init() create and assign current_migration, which means
>> it will never be null until migration_shutdown().
>>
>> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>> ---
>> migration/migration.c | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/migration/migration.c b/migration/migration.c
>> index 0fd2364961..43fd8297ef 100644
>> --- a/migration/migration.c
>> +++ b/migration/migration.c
>> @@ -1667,10 +1667,6 @@ bool migration_is_idle(void)
>> {
>> MigrationState *s = current_migration;
>>
>> - if (!s) {
>> - return true;
>> - }
>> -
>
>I'd prefer to keep that because it's used by migrate_add_blocker
>and without this check it means we'd only be able to add a blocker
>after the migration object init - which is probably fine but we
>would have to check all the cases and make sure no one breaks it in
>the future; where as this check makes it just work and we don't
>need to worry about the order.
>
Reasonable, Thanks :-)
>Dave
>
>> switch (s->state) {
>> case MIGRATION_STATUS_NONE:
>> case MIGRATION_STATUS_CANCELLED:
>> --
>> 2.19.1
>>
>--
>Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-20 1:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-26 0:42 [Qemu-devel] [PATCH] migration: current_migration is never NULL Wei Yang
2019-07-19 15:10 ` Dr. David Alan Gilbert
2019-07-20 1:37 ` Wei Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).