From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: Wei Yang <richardw.yang@linux.intel.com>,
dgilbert@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 1/2] migration: return -EINVAL directly when version_id mismatch
Date: Mon, 22 Jul 2019 15:53:38 +0800 [thread overview]
Message-ID: <20190722075339.25121-2-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190722075339.25121-1-richardw.yang@linux.intel.com>
It is not reasonable to continue when version_id mismatch.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 7e34c82a72..6bfdfae16e 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -4216,7 +4216,7 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id)
seq_iter++;
if (version_id != 4) {
- ret = -EINVAL;
+ return -EINVAL;
}
if (!migrate_use_compression()) {
--
2.17.1
next prev parent reply other threads:[~2019-07-22 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 7:53 [Qemu-devel] [PATCH 0/2] migration: cleanup ram_load Wei Yang
2019-07-22 7:53 ` Wei Yang [this message]
2019-07-23 15:44 ` [Qemu-devel] [PATCH 1/2] migration: return -EINVAL directly when version_id mismatch Dr. David Alan Gilbert
2019-07-22 7:53 ` [Qemu-devel] [PATCH 2/2] migration: extract ram_load_precopy Wei Yang
2019-07-23 16:47 ` Dr. David Alan Gilbert
2019-07-24 1:20 ` Wei Yang
2019-07-24 12:10 ` Dr. David Alan Gilbert
2019-07-24 22:14 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722075339.25121-2-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).