From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH for-4.1 0/2] block: bdrv_drained_end() changes fallout
Date: Mon, 22 Jul 2019 15:30:52 +0200 [thread overview]
Message-ID: <20190722133054.21781-1-mreitz@redhat.com> (raw)
Hi,
I noted that test-bdrv-drain sometimgs hangs (very rarely, though), and
tried to write a test that triggers the issue. I failed to do so (there
is a good reason for that, see patch 1), but on my way I noticed that
calling bdrv_set_aio_context_ignore() from any AioContext but the main
one is a bad idea. Hence patch 2.
Anyway, I found the problem, which is fixed by patch 1 -- I think it’s
rather obvious. There is no dedicated test because I don’t think it’s
possible to write one, as I explain there.
Max Reitz (2):
block: Dec. drained_end_counter before bdrv_wakeup
block: Only the main loop can change AioContexts
include/block/block.h | 8 +++-----
block.c | 13 ++++++++-----
block/io.c | 5 ++---
3 files changed, 13 insertions(+), 13 deletions(-)
--
2.21.0
next reply other threads:[~2019-07-22 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 13:30 Max Reitz [this message]
2019-07-22 13:30 ` [Qemu-devel] [PATCH for-4.1 1/2] block: Dec. drained_end_counter before bdrv_wakeup Max Reitz
2019-07-22 13:30 ` [Qemu-devel] [PATCH for-4.1 2/2] block: Only the main loop can change AioContexts Max Reitz
2019-07-23 8:52 ` Kevin Wolf
2019-07-23 9:41 ` Max Reitz
2019-07-23 10:02 ` Kevin Wolf
2019-07-23 10:21 ` Max Reitz
2019-07-23 11:06 ` Kevin Wolf
2019-07-22 17:18 ` [Qemu-devel] [PATCH for-4.1 0/2] block: bdrv_drained_end() changes fallout Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722133054.21781-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).