qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, pbonzini@redhat.com, pavel.dovgaluk@ispras.ru
Subject: [Qemu-devel] [for 4.2 PATCH 0/3] Remove time reset notifications
Date: Mon, 22 Jul 2019 16:07:14 +0100	[thread overview]
Message-ID: <20190722150717.10564-1-dgilbert@redhat.com> (raw)

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Timers have a mechanism for detecting host clock jumps; this relied
on noticing if the time had gone backwards or if it had gone forward
more than 60s since we last read it.  This had assumed that we regularly
read the time, which isn't true any more - we might not read the host
timer until the guest explicitly reads the guest RTC (e.g. hwclock).
This falsely triggers the reset mechanism.

The reset mechanism was only used by the mc146818 (i.e. PC) RTC
anyway; so lets remove it.

Dr. David Alan Gilbert (3):
  mc146818rtc: Remove reset notifiers
  timer: Remove reset notifiers
  timer: last, remove last bits of last

 hw/timer/mc146818rtc.c   | 19 -------------------
 include/qemu/timer.h     | 35 ----------------------------------
 replay/replay-snapshot.c |  3 +--
 util/qemu-timer.c        | 41 +---------------------------------------
 4 files changed, 2 insertions(+), 96 deletions(-)

-- 
2.21.0



             reply	other threads:[~2019-07-22 15:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 15:07 Dr. David Alan Gilbert (git) [this message]
2019-07-22 15:07 ` [Qemu-devel] [for 4.2 PATCH 1/3] mc146818rtc: Remove reset notifiers Dr. David Alan Gilbert (git)
2019-07-22 15:07 ` [Qemu-devel] [for 4.2 PATCH 2/3] timer: " Dr. David Alan Gilbert (git)
2019-07-22 15:07 ` [Qemu-devel] [for 4.2 PATCH 3/3] timer: last, remove last bits of last Dr. David Alan Gilbert (git)
2019-07-23  5:54   ` Pavel Dovgalyuk
2019-07-24 11:20     ` Dr. David Alan Gilbert
2019-07-22 16:46 ` [Qemu-devel] [for 4.2 PATCH 0/3] Remove time reset notifications Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722150717.10564-1-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=pavel.dovgaluk@ispras.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).