From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc/pnv: Introduce PowerNV machines with fixed CPU models
Date: Tue, 23 Jul 2019 16:37:30 +1000 [thread overview]
Message-ID: <20190723063730.GT25073@umbus.fritz.box> (raw)
In-Reply-To: <177076c3-b418-fb52-74c9-ee98f5fe4694@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]
On Tue, Jul 23, 2019 at 08:00:27AM +0200, Cédric Le Goater wrote:
> On 23/07/2019 03:38, David Gibson wrote:
> > On Mon, Jul 22, 2019 at 08:23:47PM +0200, Cédric Le Goater wrote:
> >> Make the current "powernv" machine an abstract type and derive from it
> >> new machines with specific CPU models: power8, power8e, power8nvl,
> >> power9.
> >>
> >> The "powernv" machine is now an alias on the "powernv9" machine.
> >>
> >> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> >
> > Ah, sorry, I wasn't clear here. I don't think we need a different
> > machine type for every cpu model, I just think we should have powernv8
> > and powernv9. POWER8E and POWER8NVL don't significantly change the
> > system design (IIUC) so they can still be done with "-machine powernv8
> > -cpu POWER8E" or whatever. I expect the same will be true for POWER9'
> > when that comes along
>
> I understand but I am afraid we will to have one machine per CPU family
> because POWER8E and POWER8NVL already have their own PnvChip :
>
> DEFINE_PNV8_CHIP_TYPE(TYPE_PNV_CHIP_POWER8, pnv_chip_power8_class_init),
> DEFINE_PNV8_CHIP_TYPE(TYPE_PNV_CHIP_POWER8E, pnv_chip_power8e_class_init),
> DEFINE_PNV8_CHIP_TYPE(TYPE_PNV_CHIP_POWER8NVL,
> pnv_chip_power8nvl_class_init),
Hrm. Is there an actual reason we need different chip classes for
these? Even if there is, I don't see an inherent reason that implies
separate machine classes as well.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-07-23 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:23 [Qemu-devel] [PATCH] ppc/pnv: Introduce PowerNV machines with fixed CPU models Cédric Le Goater
2019-07-23 1:38 ` David Gibson
2019-07-23 6:00 ` Cédric Le Goater
2019-07-23 6:37 ` David Gibson [this message]
2019-07-24 9:32 ` Cédric Le Goater
2019-07-25 3:27 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723063730.GT25073@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).