From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Kevin Wolf" <kwolf@redhat.com>, "Thomas Huth" <thuth@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PULL 20/23] tests/qemu-iotests/check: Allow tests without groups
Date: Tue, 23 Jul 2019 11:36:09 +0100 [thread overview]
Message-ID: <20190723103612.5600-21-alex.bennee@linaro.org> (raw)
In-Reply-To: <20190723103612.5600-1-alex.bennee@linaro.org>
From: Thomas Huth <thuth@redhat.com>
The regular expressions in the "check" script currently expect that there
is always a space after the test number in the group file, so you can't
have a test in there without a group unless the line still ends with a
space - which is quite error prone since some editors might remove spaces
at the end of lines automatically.
Thus let's fix the regular expressions so that it is also possible to
have lines with one test number only in the group file.
Suggested-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20190717111947.30356-2-thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index f925606cc52..c24874ff4aa 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -488,7 +488,7 @@ testlist options
BEGIN { for (t='$start'; t<='$end'; t++) printf "%03d\n",t }' \
| while read id
do
- if grep -s "^$id " "$source_iotests/group" >/dev/null
+ if grep -s "^$id\( \|\$\)" "$source_iotests/group" >/dev/null
then
# in group file ... OK
echo $id >>$tmp.list
@@ -547,7 +547,7 @@ else
touch $tmp.list
else
# no test numbers, do everything from group file
- sed -n -e '/^[0-9][0-9][0-9]*/s/[ ].*//p' <"$source_iotests/group" >$tmp.list
+ sed -n -e '/^[0-9][0-9][0-9]*/s/^\([0-9]*\).*/\1/p' <"$source_iotests/group" >$tmp.list
fi
fi
--
2.20.1
next prev parent reply other threads:[~2019-07-23 10:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 10:35 [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!) Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 01/23] archive-source: also create a stash for submodules Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 02/23] tests/docker: add test-misc for building tools & docs Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 03/23] tests/docker: Install Sphinx in the Ubuntu images Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 04/23] tests/docker: Install Sphinx in the Fedora image Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 05/23] tests/docker: Install Ubuntu images noninteractively Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 06/23] tests/migration-test: don't spam the logs when we fail Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 07/23] tests/dockerfiles: update the win cross builds to stretch Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 08/23] shippable: re-enable the windows cross builds Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 09/23] tests/docker: Install Sphinx in the Debian images Alex Bennée
2019-07-23 10:35 ` [Qemu-devel] [PULL 10/23] tests/docker: Install the NSIS tools in the MinGW capable images Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 11/23] tests/docker: Set the correct cross-PKG_CONFIG_PATH in the MXE images Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 12/23] tests/docker: Install texinfo in the Fedora image Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 13/23] buildsys: The NSIS Windows build requires the documentation installed Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 14/23] buildsys: The NSIS Windows build requires qemu-nsis.bmp installed Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 15/23] tests/docker: Let the test-mingw test generate a NSIS installer Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 16/23] NSIS: Add missing firmware blobs Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 17/23] hw/i386: also turn off VMMOUSE is VMPORT is disabled Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 18/23] travis: enable travis_retry for check phase Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 19/23] tests/docker: invoke the DEBUG shell with --noprofile/--norc Alex Bennée
2019-07-23 10:36 ` Alex Bennée [this message]
2019-07-23 10:36 ` [Qemu-devel] [PULL 21/23] tests/qemu-iotests/group: Remove some more tests from the "auto" group Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 22/23] tests: Run the iotests during "make check" again Alex Bennée
2019-07-23 10:36 ` [Qemu-devel] [PULL 23/23] gitlab-ci: Remove qcow2 tests that are handled by "make check" already Alex Bennée
2019-07-23 11:35 ` [Qemu-devel] [PULL for 4.1-rc2 00/23] testing updates (green CI!) Peter Maydell
2019-07-23 11:46 ` Alex Bennée
2019-07-23 12:16 ` Philippe Mathieu-Daudé
2019-07-23 12:31 ` Peter Maydell
2019-07-23 12:58 ` Alex Bennée
2019-07-23 13:01 ` Peter Maydell
2019-07-23 15:56 ` Thomas Huth
2019-07-23 12:57 ` Alex Bennée
2019-07-23 13:33 ` Peter Maydell
2019-07-23 13:47 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723103612.5600-21-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).