From: Stefan Hajnoczi <stefanha@gmail.com>
To: P J P <ppandit@redhat.com>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Jason Wang" <jasowang@redhat.com>, "Li Qiang" <liq3ea@gmail.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Prasad J Pandit" <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls
Date: Tue, 23 Jul 2019 14:03:26 +0100 [thread overview]
Message-ID: <20190723130326.GC5445@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190723104754.29324-4-ppandit@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 454 bytes --]
On Tue, Jul 23, 2019 at 04:17:54PM +0530, P J P wrote:
> - snprintf(helper_cmd, sizeof(helper_cmd), "%s %s %s %s",
> - helper, "--use-vnet", fd_buf, br_buf);
> + helper_cmd = g_strdup_printf("%s %s %s %s", helper,
> + "--use-vnet", fd_buf, br_buf ? br_buf : "");
The change to the br_buf argument isn't covered in the commit
description. Why did you change this, was it a bug, etc?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-23 13:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 10:47 [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ P J P
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict " P J P
2019-07-23 13:10 ` Stefan Hajnoczi
2019-07-23 13:12 ` Daniel P. Berrangé
2019-07-23 15:07 ` Li Qiang
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
2019-07-23 13:00 ` Stefan Hajnoczi
2019-07-23 13:12 ` Daniel P. Berrangé
2019-07-23 15:07 ` Li Qiang
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls P J P
2019-07-23 13:03 ` Stefan Hajnoczi [this message]
2019-07-23 15:43 ` Li Qiang
2019-07-24 5:48 ` P J P
2019-07-29 15:04 ` Stefan Hajnoczi
2019-07-31 4:58 ` Jason Wang
2019-07-31 6:42 ` P J P
2019-07-31 6:59 ` Jason Wang
2019-07-31 9:23 ` P J P
2019-07-23 13:13 ` Daniel P. Berrangé
2019-07-23 17:44 ` [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ no-reply
2019-07-25 4:01 ` Jason Wang
2019-07-25 10:20 ` P J P
2019-07-26 10:26 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723130326.GC5445@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).