From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
mreitz@redhat.com, den@openvz.org, jsnow@redhat.com
Subject: [Qemu-devel] [PATCH v3 for-4.1? 0/9] qcow2-bitmaps: rewrite reopening logic
Date: Thu, 25 Jul 2019 12:18:51 +0300 [thread overview]
Message-ID: <20190725091900.30542-1-vsementsov@virtuozzo.com> (raw)
Hi all!
Bitmaps reopening is buggy, we may easily produce broken incremental
backup if we do temporary snapshot. Let's fix it!
v3:
02: John's events_wait already merged in, so my 02 from v2 is not needed.
Instead, add two simple logging wrappers here
03: rebase on 02 - use new wrappers, move to 260
05: add John's r-b
06: improve function docs [John], add John's r-b
v2:
01: new
02-03: test: splat into two patches, some wording
improvements and event_wait improved
04: add John's r-b
05: new
06-09: fixes: changed, splat, use patch 01
Vladimir Sementsov-Ogievskiy (9):
block: add .bdrv_need_rw_file_child_during_reopen_rw handler
iotests.py: add event_wait_log and events_wait_log helpers
iotests: add test 260 to check bitmap life after snapshot + commit
block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps
block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint()
block/qcow2-bitmap: do not remove bitmaps on reopen-ro
block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw
block/qcow2-bitmap: fix reopening bitmaps to RW
qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_prepare
block/qcow2.h | 6 +-
include/block/block_int.h | 8 +-
include/block/dirty-bitmap.h | 1 -
block.c | 163 +++++++++++++++++++++++++++-------
block/dirty-bitmap.c | 12 ---
block/qcow2-bitmap.c | 149 +++++++++++++++++++------------
block/qcow2.c | 9 +-
tests/qemu-iotests/260 | 87 ++++++++++++++++++
tests/qemu-iotests/260.out | 52 +++++++++++
tests/qemu-iotests/group | 1 +
tests/qemu-iotests/iotests.py | 10 +++
11 files changed, 384 insertions(+), 114 deletions(-)
create mode 100755 tests/qemu-iotests/260
create mode 100644 tests/qemu-iotests/260.out
--
2.18.0
next reply other threads:[~2019-07-25 9:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 9:18 Vladimir Sementsov-Ogievskiy [this message]
2019-07-25 9:18 ` [Qemu-devel] [PATCH v3 1/9] block: add .bdrv_need_rw_file_child_during_reopen_rw handler Vladimir Sementsov-Ogievskiy
2019-07-31 12:09 ` Max Reitz
2019-08-01 14:02 ` Vladimir Sementsov-Ogievskiy
2019-08-01 19:06 ` Max Reitz
2019-08-02 8:49 ` Vladimir Sementsov-Ogievskiy
2019-08-02 15:42 ` Kevin Wolf
2019-08-02 16:23 ` Vladimir Sementsov-Ogievskiy
2019-08-02 16:41 ` Vladimir Sementsov-Ogievskiy
2019-07-25 9:18 ` [Qemu-devel] [PATCH v3 2/9] iotests.py: add event_wait_log and events_wait_log helpers Vladimir Sementsov-Ogievskiy
2019-07-25 9:18 ` [Qemu-devel] [PATCH v3 3/9] iotests: add test 260 to check bitmap life after snapshot + commit Vladimir Sementsov-Ogievskiy
2019-07-25 9:18 ` [Qemu-devel] [PATCH v3 4/9] block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps Vladimir Sementsov-Ogievskiy
2019-07-25 9:18 ` [Qemu-devel] [PATCH v3 5/9] block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint() Vladimir Sementsov-Ogievskiy
2019-07-25 9:18 ` [Qemu-devel] [PATCH v3 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro Vladimir Sementsov-Ogievskiy
2019-07-25 9:18 ` [Qemu-devel] [PATCH v3 7/9] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw Vladimir Sementsov-Ogievskiy
2019-07-25 9:18 ` [Qemu-devel] [PATCH v3 8/9] block/qcow2-bitmap: fix reopening bitmaps to RW Vladimir Sementsov-Ogievskiy
2019-07-25 9:19 ` [Qemu-devel] [PATCH v3 9/9] qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_prepare Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725091900.30542-1-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).