From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: den@openvz.org,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
kraxel@redhat.com, Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive
Date: Thu, 25 Jul 2019 17:50:39 +0100 [thread overview]
Message-ID: <20190725165039.GS6930@redhat.com> (raw)
In-Reply-To: <5579a1f8-2518-0cd3-3b0c-47cb4adcee73@redhat.com>
On Thu, Jul 25, 2019 at 11:38:56AM -0500, Eric Blake wrote:
> On 7/25/19 10:26 AM, Markus Armbruster wrote:
> > Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> writes:
> >
> >> It's needed to provide keepalive for nbd client to track server
> >> availability.
> >>
> >> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> >
> > Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> It looks like this could go in any number of ways (Markus since it
> touches qapi, Dan since it touches sockets, or me since it was written
> for use with NBD); but unless anyone complains, I'm happy to queue this
> through my NBD tree for 4.2.
I'm fine with you queuing it, since I have nothing pending myself
to bundle it up with
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-07-25 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 9:49 [Qemu-devel] [PATCH v4] qapi: Add InetSocketAddress member keep-alive Vladimir Sementsov-Ogievskiy
2019-07-25 15:26 ` Markus Armbruster
2019-07-25 16:38 ` Eric Blake
2019-07-25 16:50 ` Daniel P. Berrangé [this message]
2019-07-25 19:59 ` Markus Armbruster
2019-07-29 20:51 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725165039.GS6930@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).