qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: virtio-fs@redhat.com, qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 2/5] virtiofsd: prevent lo_lookup() NULL pointer dereference
Date: Fri, 26 Jul 2019 10:11:00 +0100	[thread overview]
Message-ID: <20190726091103.23503-3-stefanha@redhat.com> (raw)
In-Reply-To: <20190726091103.23503-1-stefanha@redhat.com>

Most lo_do_lookup() have already checked that the parent inode exists.
lo_lookup() hasn't and can therefore hit a NULL pointer dereference when
lo_inode(req, parent) returns NULL.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 contrib/virtiofsd/passthrough_ll.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/contrib/virtiofsd/passthrough_ll.c b/contrib/virtiofsd/passthrough_ll.c
index 9ae1381618..277a17fc03 100644
--- a/contrib/virtiofsd/passthrough_ll.c
+++ b/contrib/virtiofsd/passthrough_ll.c
@@ -766,6 +766,10 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t parent, const char *name,
 	struct lo_data *lo = lo_data(req);
 	struct lo_inode *inode, *dir = lo_inode(req, parent);
 
+	if (!dir) {
+		return EBADF;
+	}
+
 	memset(e, 0, sizeof(*e));
 	e->attr_timeout = lo->timeout;
 	e->entry_timeout = lo->timeout;
-- 
2.21.0



  parent reply	other threads:[~2019-07-26  9:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-26  9:10 [Qemu-devel] [PATCH 0/5] virtiofsd: multithreading preparation Stefan Hajnoczi
2019-07-26  9:10 ` [Qemu-devel] [PATCH 1/5] virtiofsd: skip unnecessary vu_queue_get_avail_bytes() Stefan Hajnoczi
2019-07-26 21:35   ` [Qemu-devel] [Virtio-fs] " Liu Bo
2019-07-31 16:50   ` [Qemu-devel] " Dr. David Alan Gilbert
2019-07-26  9:11 ` Stefan Hajnoczi [this message]
2019-07-26 21:26   ` [Qemu-devel] [Virtio-fs] [PATCH 2/5] virtiofsd: prevent lo_lookup() NULL pointer dereference Liu Bo
2019-07-29  8:15     ` Stefan Hajnoczi
2019-07-28  2:06   ` piaojun
2019-07-29 12:35   ` piaojun
2019-07-29 15:41     ` Stefan Hajnoczi
2019-07-30  0:34       ` piaojun
2019-07-26  9:11 ` [Qemu-devel] [PATCH 3/5] virtiofsd: make lo_release() atomic Stefan Hajnoczi
2019-07-31 16:56   ` Dr. David Alan Gilbert
2019-07-26  9:11 ` [Qemu-devel] [PATCH 4/5] virtiofsd: drop lo_dirp->fd field Stefan Hajnoczi
2019-07-31 17:27   ` Dr. David Alan Gilbert
2019-08-01  9:07     ` Stefan Hajnoczi
2019-07-26  9:11 ` [Qemu-devel] [PATCH 5/5] virtiofsd: prevent races with lo_dirp_put() Stefan Hajnoczi
2019-07-31 17:44   ` Dr. David Alan Gilbert
2019-08-01  9:15     ` Stefan Hajnoczi
2019-08-01 11:14       ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190726091103.23503-3-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).