From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2734C7618B for ; Fri, 26 Jul 2019 15:44:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9911F20838 for ; Fri, 26 Jul 2019 15:44:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9911F20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr2OA-0002DS-Ft for qemu-devel@archiver.kernel.org; Fri, 26 Jul 2019 11:44:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56765) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr2O0-0001l9-5B for qemu-devel@nongnu.org; Fri, 26 Jul 2019 11:44:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hr2Nx-0000gd-SQ for qemu-devel@nongnu.org; Fri, 26 Jul 2019 11:43:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55142) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hr2Nv-0000OZ-43; Fri, 26 Jul 2019 11:43:55 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E2840308A968; Fri, 26 Jul 2019 15:43:51 +0000 (UTC) Received: from redhat.com (ovpn-112-49.ams2.redhat.com [10.36.112.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 637D017C43; Fri, 26 Jul 2019 15:43:49 +0000 (UTC) Date: Fri, 26 Jul 2019 16:43:46 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Richard W.M. Jones" Message-ID: <20190726154346.GL7236@redhat.com> References: <20190726140954.31921-1-ptoscano@redhat.com> <20190726142710.GY3888@redhat.com> <4422965.dTeGc4fl6G@lindworm.usersys.redhat.com> <94a702f6-10a3-4705-4ec4-496a1b5b0515@redhat.com> <20190726153527.GD3888@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190726153527.GD3888@redhat.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Fri, 26 Jul 2019 15:43:51 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 0/2] ssh: add password and privkey auth methods X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: kwolf@redhat.com, pkrempa@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, Pino Toscano Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 26, 2019 at 04:35:27PM +0100, Richard W.M. Jones wrote: > On Fri, Jul 26, 2019 at 10:06:43AM -0500, Eric Blake wrote: > > On 7/26/19 9:45 AM, Pino Toscano wrote: > > > On Friday, 26 July 2019 16:27:11 CEST Richard W.M. Jones wrote: > > >> On Fri, Jul 26, 2019 at 04:09:52PM +0200, Pino Toscano wrote: > > >>> These two patches add the password and private key authentication > > >>> methods to the ssh block driver, using secure objects for > > >>> passwords/passphrases. > > >> > > >> I was attempting to test this but couldn't work out the full command > > >> line to use it (with qemu-img). I got as far as: > > >> > > >> $ ./qemu-img convert -p 'json:{ "file.driver": "ssh", "file.host": "devr7", "file.path": "/var/tmp/root", "file.password-secret": "..." }' /var/tmp/root > > >> > > >> I guess the secret should be specified using --object, but at that > > >> point I gave up. > > > > > > Almost there :) add e.g. > > > --object 'secret,id=sec0,file=passwd' > > > as parameter for the convert command (so after it, not before), and then > > > set 'sec0' as value for file.password-secret. Of course 'sec0' is > > > arbitrary, any other QEMU id will do. > > > > > > A long helpful comment in include/crypto/secret.h explains the basics > > > of the crypto objects. > > > > That is useful information, but even more useful if you amend the commit > > message to include a working example command line rather than making > > readers chase down the docs :) > > > > Untested, but piecing together what I know from my work on qemu-nbd > > encryption, it seems like this should be a starting point for such a > > command: > > > > qemu-img convert -p --imageopts --object secret,id=sec0,file=passwd \ > > driver=ssh,host=devr7,path=/var/tmp/root,password-secret=sec0 \ > > /var/tmp/copy > > --imageopts isn't necessary. This was the command that worked for me: > > unset SSH_AUTH_SOCK; ./qemu-img convert -p --object 'secret,id=sec0,file=/tmp/passwd' 'json:{ "file.driver": "ssh", "file.host": "devr7", "file.path": "/var/tmp/root", "file.password-secret": "sec0" }' /var/tmp/root Right you didn't need --imageopts because you used the json filename syntax. --imageopts is for telling it to intepret the filename as key,value pairs as in Eric's example. json & imageopts syntaxes are equally expressive, so pick which you prefer. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|