From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, groug@kaod.org,
Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>,
clg@kaod.org, qemu-ppc@nongnu.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PULL 1/2] spapr/irq: Inform the user when falling back to emulated IC
Date: Sun, 28 Jul 2019 16:43:54 +1000 [thread overview]
Message-ID: <20190728064355.2605-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20190728064355.2605-1-david@gibson.dropbear.id.au>
From: Greg Kurz <groug@kaod.org>
Just to give an indication to the user that the error condition is
handled and how.
Reported-by: Satheesh Rajendran <sathnaga@linux.vnet.ibm.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <156398743479.546975.14566809803480887488.stgit@bahia.lan>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr_irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr_irq.c b/hw/ppc/spapr_irq.c
index ff3df0bbd8..d07aed8ca9 100644
--- a/hw/ppc/spapr_irq.c
+++ b/hw/ppc/spapr_irq.c
@@ -86,6 +86,7 @@ static void spapr_irq_init_kvm(SpaprMachineState *spapr,
* emulated mode
*/
error_prepend(&local_err, "kernel_irqchip allowed but unavailable: ");
+ error_append_hint(&local_err, "Falling back to kernel-irqchip=off\n");
warn_report_err(local_err);
}
}
--
2.21.0
next prev parent reply other threads:[~2019-07-28 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 6:43 [Qemu-devel] [PULL 0/2] ppc-for-4.1 queue 20190728 David Gibson
2019-07-28 6:43 ` David Gibson [this message]
2019-07-28 6:43 ` [Qemu-devel] [PULL 2/2] xics/kvm: Fix fallback to emulated XICS David Gibson
2019-07-29 11:04 ` [Qemu-devel] [PULL 0/2] ppc-for-4.1 queue 20190728 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728064355.2605-2-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sathnaga@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).