From: Wei Yang <richardw.yang@linux.intel.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, david@redhat.com,
Wei Yang <richardw.yang@linux.intel.com>,
mst@redhat.com
Subject: [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range
Date: Sun, 28 Jul 2019 21:13:04 +0800 [thread overview]
Message-ID: <20190728131304.1282-4-richardw.yang@linux.intel.com> (raw)
In-Reply-To: <20190728131304.1282-1-richardw.yang@linux.intel.com>
The memory-device list built by memory_device_build_list is ordered by
its address, this means if the tmp range exceed the hinted range, all
the following range will not overlap with it.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
hw/mem/memory-device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 413b514586..aea47ab3e8 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -180,7 +180,7 @@ static uint64_t memory_device_get_free_addr(MachineState *ms,
range_make_empty(&new);
break;
}
- } else if (!hint) {
+ } else if (!hint || range_lob(&tmp) > range_upb(&new)) {
break;
}
}
--
2.17.1
next prev parent reply other threads:[~2019-07-28 13:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 13:13 [Qemu-devel] [PATCH 0/3] memory-device: refine memory_device_get_free_addr Wei Yang
2019-07-28 13:13 ` [Qemu-devel] [PATCH 1/3] memory-device: not necessary to use goto for the last check Wei Yang
2019-07-29 6:50 ` Igor Mammedov
2019-07-29 7:30 ` David Hildenbrand
2019-07-28 13:13 ` [Qemu-devel] [PATCH 2/3] memory-device: break the loop if no hint is provided Wei Yang
2019-07-29 7:04 ` Igor Mammedov
2019-07-29 7:49 ` Wei Yang
2019-07-29 7:45 ` David Hildenbrand
2019-07-29 7:50 ` Wei Yang
2019-07-28 13:13 ` Wei Yang [this message]
2019-07-29 7:49 ` [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range David Hildenbrand
2019-07-29 7:53 ` David Hildenbrand
2019-07-29 8:30 ` Wei Yang
2019-07-29 8:42 ` David Hildenbrand
2019-07-29 8:30 ` Igor Mammedov
2019-07-29 12:56 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728131304.1282-4-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).