From: Igor Mammedov <imammedo@redhat.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: david@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] memory-device: not necessary to use goto for the last check
Date: Mon, 29 Jul 2019 08:50:57 +0200 [thread overview]
Message-ID: <20190729085057.462ad378@redhat.com> (raw)
In-Reply-To: <20190728131304.1282-2-richardw.yang@linux.intel.com>
On Sun, 28 Jul 2019 21:13:02 +0800
Wei Yang <richardw.yang@linux.intel.com> wrote:
> We are already at the last condition check.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/mem/memory-device.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index 5f2c408036..df3261b32a 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -186,7 +186,6 @@ static uint64_t memory_device_get_free_addr(MachineState *ms,
> if (!range_contains_range(&as, &new)) {
> error_setg(errp, "could not find position in guest address space for "
> "memory device - memory fragmented due to alignments");
> - goto out;
> }
> out:
> g_slist_free(list);
next prev parent reply other threads:[~2019-07-29 6:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 13:13 [Qemu-devel] [PATCH 0/3] memory-device: refine memory_device_get_free_addr Wei Yang
2019-07-28 13:13 ` [Qemu-devel] [PATCH 1/3] memory-device: not necessary to use goto for the last check Wei Yang
2019-07-29 6:50 ` Igor Mammedov [this message]
2019-07-29 7:30 ` David Hildenbrand
2019-07-28 13:13 ` [Qemu-devel] [PATCH 2/3] memory-device: break the loop if no hint is provided Wei Yang
2019-07-29 7:04 ` Igor Mammedov
2019-07-29 7:49 ` Wei Yang
2019-07-29 7:45 ` David Hildenbrand
2019-07-29 7:50 ` Wei Yang
2019-07-28 13:13 ` [Qemu-devel] [PATCH 3/3] memory-device: break the loop if tmp exceed the hinted range Wei Yang
2019-07-29 7:49 ` David Hildenbrand
2019-07-29 7:53 ` David Hildenbrand
2019-07-29 8:30 ` Wei Yang
2019-07-29 8:42 ` David Hildenbrand
2019-07-29 8:30 ` Igor Mammedov
2019-07-29 12:56 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729085057.462ad378@redhat.com \
--to=imammedo@redhat.com \
--cc=david@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richardw.yang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).