From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, qemu-s390x@nongnu.org, dgilbert@redhat.com
Subject: [Qemu-devel] [PATCH RFC 1/2] memory: make MemoryRegion alias migratable
Date: Mon, 29 Jul 2019 10:52:28 -0400 [thread overview]
Message-ID: <20190729145229.4333-2-imammedo@redhat.com> (raw)
In-Reply-To: <20190729145229.4333-1-imammedo@redhat.com>
use qemu_ram_alloc_from_ptr() to create aliased RAMBlock
to the part of original memory region.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
exec.c | 7 ++++---
memory.c | 5 +++++
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/exec.c b/exec.c
index 3e78de3b8f..daef0cd54f 100644
--- a/exec.c
+++ b/exec.c
@@ -2313,7 +2313,7 @@ static void ram_block_add(RAMBlock *new_block, Error **errp, bool shared)
new_block->used_length,
DIRTY_CLIENTS_ALL);
- if (new_block->host) {
+ if (new_block->host && !new_block->mr->alias) {
qemu_ram_setup_dump(new_block->host, new_block->max_length);
qemu_madvise(new_block->host, new_block->max_length, QEMU_MADV_HUGEPAGE);
/* MADV_DONTFORK is also needed by KVM in absence of synchronous MMU */
@@ -2671,7 +2671,8 @@ RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset,
rcu_read_lock();
block = atomic_rcu_read(&ram_list.mru_block);
- if (block && block->host && host - block->host < block->max_length) {
+ if (block && !block->mr->alias && block->host &&
+ host - block->host < block->max_length) {
goto found;
}
@@ -2680,7 +2681,7 @@ RAMBlock *qemu_ram_block_from_host(void *ptr, bool round_offset,
if (block->host == NULL) {
continue;
}
- if (host - block->host < block->max_length) {
+ if (!block->mr->alias && host - block->host < block->max_length) {
goto found;
}
}
diff --git a/memory.c b/memory.c
index 5d8c9a9234..d710c17a26 100644
--- a/memory.c
+++ b/memory.c
@@ -1678,6 +1678,11 @@ void memory_region_init_alias(MemoryRegion *mr,
memory_region_init(mr, owner, name, size);
mr->alias = orig;
mr->alias_offset = offset;
+ if (orig->ram_block && size) {
+ mr->ram_block = qemu_ram_alloc_from_ptr(size,
+ orig->ram_block->host + offset,
+ mr, &error_fatal);
+ }
}
void memory_region_init_rom_nomigrate(MemoryRegion *mr,
--
2.18.1
next prev parent reply other threads:[~2019-07-29 14:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 14:52 [Qemu-devel] [PATCH RFC 0/2] s390: stop abusing memory_region_allocate_system_memory() Igor Mammedov
2019-07-29 14:52 ` Igor Mammedov [this message]
2019-07-29 17:53 ` [Qemu-devel] [PATCH RFC 1/2] memory: make MemoryRegion alias migratable Dr. David Alan Gilbert
2019-07-30 13:25 ` Igor Mammedov
2019-07-30 13:34 ` Paolo Bonzini
2019-07-30 14:35 ` Igor Mammedov
2019-07-30 15:41 ` Dr. David Alan Gilbert
2019-07-29 14:52 ` [Qemu-devel] [PATCH RFC 2/2] s390: do not call memory_region_allocate_system_memory() multiple times Igor Mammedov
2019-07-29 14:58 ` [Qemu-devel] [PATCH RFC 0/2] s390: stop abusing memory_region_allocate_system_memory() Cornelia Huck
2019-07-30 15:22 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2019-07-30 15:49 ` Igor Mammedov
2019-08-02 8:04 ` David Hildenbrand
2019-08-02 8:23 ` David Hildenbrand
2019-08-02 8:26 ` David Hildenbrand
2019-08-02 8:29 ` Christian Borntraeger
2019-08-02 8:37 ` David Hildenbrand
2019-08-02 10:24 ` Christian Borntraeger
2019-08-02 9:18 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729145229.4333-2-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).