From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4048C7618B for ; Mon, 29 Jul 2019 16:34:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB8C3206BA for ; Mon, 29 Jul 2019 16:34:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB8C3206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs8b5-00085r-20 for qemu-devel@archiver.kernel.org; Mon, 29 Jul 2019 12:34:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59569) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs8Yl-0005A2-HZ for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:31:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hs8Yg-0007W9-UF for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:31:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52966) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hs8Yg-0007U8-OI for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:31:34 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3D45630860C3 for ; Mon, 29 Jul 2019 16:31:32 +0000 (UTC) Received: from redhat.com (ovpn-112-51.ams2.redhat.com [10.36.112.51]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2688A5D6A5; Mon, 29 Jul 2019 16:31:27 +0000 (UTC) Date: Mon, 29 Jul 2019 17:31:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: "Dr. David Alan Gilbert (git)" Message-ID: <20190729163124.GU32718@redhat.com> References: <20190729162903.4489-1-dgilbert@redhat.com> <20190729162903.4489-3-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190729162903.4489-3-dgilbert@redhat.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Mon, 29 Jul 2019 16:31:32 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 2/2] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: cohuck@redhat.com, qemu-devel@nongnu.org, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 29, 2019 at 05:29:03PM +0100, Dr. David Alan Gilbert (git) wr= ote: > From: "Dr. David Alan Gilbert" >=20 > This reverts commit f2784eed306449c3d04a71a05ed6463b8289aedf > since that accidentally removes the PCIe capabilities from virtio > devices because virtio_pci_dc_realize is called before the new 'mode' > flag is set. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > hw/core/machine.c | 23 +++-------------------- > hw/display/virtio-gpu-pci.c | 4 +--- > hw/display/virtio-vga.c | 4 +--- > hw/virtio/virtio-crypto-pci.c | 4 +--- > hw/virtio/virtio-input-pci.c | 4 +--- > hw/virtio/virtio-pci.c | 26 ++++++++++---------------- > hw/virtio/virtio-pci.h | 31 ++++++------------------------- > 7 files changed, 23 insertions(+), 73 deletions(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberran= ge :| |: https://libvirt.org -o- https://fstop138.berrange.c= om :| |: https://entangle-photo.org -o- https://www.instagram.com/dberran= ge :|