From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980A2C7618B for ; Mon, 29 Jul 2019 16:36:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70BBC206BA for ; Mon, 29 Jul 2019 16:36:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70BBC206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs8dY-0002Ff-Ol for qemu-devel@archiver.kernel.org; Mon, 29 Jul 2019 12:36:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60330) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs8cn-0001Ph-Sx for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:35:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hs8cm-0002xB-Uy for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:35:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47326) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hs8cm-0002wm-OR for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:35:48 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8AC644E82F for ; Mon, 29 Jul 2019 16:35:47 +0000 (UTC) Received: from work-vm (ovpn-117-222.ams2.redhat.com [10.36.117.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D57119C58; Mon, 29 Jul 2019 16:35:44 +0000 (UTC) Date: Mon, 29 Jul 2019 17:35:41 +0100 From: "Dr. David Alan Gilbert" To: Cornelia Huck Message-ID: <20190729163541.GJ2756@work-vm> References: <20190729162903.4489-1-dgilbert@redhat.com> <20190729183232.22bcbb26.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190729183232.22bcbb26.cohuck@redhat.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 29 Jul 2019 16:35:47 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [For 4.1 PATCH v2 0/2] Reversions to fix PCIe in virtio X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, qemu-devel@nongnu.org, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Cornelia Huck (cohuck@redhat.com) wrote: > On Mon, 29 Jul 2019 17:29:01 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > Revert a couple of patches that break PCIe capabilities in virtio > > devices. The 'optional' revert is just reverted to make the main > > reversion trivial. > > Don't want to spoil the party here; but wasn't the optional stuff > removed because it was deemed to be a bad idea? I'm perfectly happy to go either way with this; it maybe a bad idea but it's harmless I think. Dave > > > > Symptom: > > Loss of PCIe capabilities in virtio devices hung off PCIe bridges > > > > Signed-off-by: Dr. David Alan Gilbert > > > > > > Dr. David Alan Gilbert (2): > > Revert "Revert "globals: Allow global properties to be optional"" > > Revert "hw: report invalid disable-legacy|modern usage for > > virtio-1-only devs" > > > > hw/core/machine.c | 23 +++-------------------- > > hw/display/virtio-gpu-pci.c | 4 +--- > > hw/display/virtio-vga.c | 4 +--- > > hw/virtio/virtio-crypto-pci.c | 4 +--- > > hw/virtio/virtio-input-pci.c | 4 +--- > > hw/virtio/virtio-pci.c | 26 ++++++++++---------------- > > hw/virtio/virtio-pci.h | 31 ++++++------------------------- > > include/hw/qdev-core.h | 3 +++ > > qom/object.c | 3 +++ > > 9 files changed, 29 insertions(+), 73 deletions(-) > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK