From: Cornelia Huck <cohuck@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: berrange@redhat.com, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] Revert "Revert "globals: Allow global properties to be optional""
Date: Mon, 29 Jul 2019 18:46:04 +0200 [thread overview]
Message-ID: <20190729184604.3981788b.cohuck@redhat.com> (raw)
In-Reply-To: <20190729162903.4489-2-dgilbert@redhat.com>
On Mon, 29 Jul 2019 17:29:02 +0100
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> This reverts commit 8fa70dbd8bb478d9483c1da3e9976a2d86b3f9a0.
>
> Because we're about to revert it's neighbour and thus uses an optional
> again.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> include/hw/qdev-core.h | 3 +++
> qom/object.c | 3 +++
> 2 files changed, 6 insertions(+)
As discussed on IRC, the 'bugs' mentioned in that commit were related
to the other patch that is being reverted; so I don't really mind it
for 4.1 (IOW, either of the two revert approaches should be fine.)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-07-29 16:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 16:29 [Qemu-devel] [For 4.1 PATCH v2 0/2] Reversions to fix PCIe in virtio Dr. David Alan Gilbert (git)
2019-07-29 16:29 ` [Qemu-devel] [PATCH v2 1/2] Revert "Revert "globals: Allow global properties to be optional"" Dr. David Alan Gilbert (git)
2019-07-29 16:30 ` Daniel P. Berrangé
2019-07-29 16:46 ` Cornelia Huck [this message]
2019-07-29 21:16 ` [Qemu-devel] [PULL 1/3] " Michael S. Tsirkin
2019-07-29 16:29 ` [Qemu-devel] [PATCH v2 2/2] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs" Dr. David Alan Gilbert (git)
2019-07-29 16:31 ` Daniel P. Berrangé
2019-07-29 16:46 ` Cornelia Huck
2019-07-29 21:16 ` [Qemu-devel] [PULL 2/3] " Michael S. Tsirkin
2019-07-29 16:32 ` [Qemu-devel] [For 4.1 PATCH v2 0/2] Reversions to fix PCIe in virtio Cornelia Huck
2019-07-29 16:35 ` Dr. David Alan Gilbert
2019-07-29 16:43 ` Peter Maydell
2019-07-29 16:45 ` Daniel P. Berrangé
-- strict thread matches above, loose matches on Subject: below --
2019-07-29 21:15 [Qemu-devel] [PULL 0/3] virtio, pc: fixes Michael S. Tsirkin
2019-07-23 16:08 ` [Qemu-devel] [PATCH] pc-dimm: fix crash when invalid slot number is used Igor Mammedov
2019-07-24 3:18 ` David Gibson
2019-07-24 6:13 ` Li Qiang
2019-07-24 6:39 ` Pankaj Gupta
2019-07-29 21:16 ` [Qemu-devel] [PULL 3/3] " Michael S. Tsirkin
2019-07-30 12:36 ` Igor Mammedov
2019-07-30 15:50 ` Michael S. Tsirkin
2019-07-30 9:44 ` [Qemu-devel] [PULL 0/3] virtio, pc: fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729184604.3981788b.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).