From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39AB6C7618B for ; Mon, 29 Jul 2019 16:49:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BD0D206A2 for ; Mon, 29 Jul 2019 16:49:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BD0D206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55162 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs8qU-00035p-8Q for qemu-devel@archiver.kernel.org; Mon, 29 Jul 2019 12:49:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33866) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs8ms-0007ja-7H for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:46:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hs8mr-0000rF-Cb for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:46:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49884) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hs8mp-0000or-9X for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:46:13 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CAEAB8E22B for ; Mon, 29 Jul 2019 16:46:09 +0000 (UTC) Received: from gondolin (dhcp-192-232.str.redhat.com [10.33.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5BE260856; Mon, 29 Jul 2019 16:46:06 +0000 (UTC) Date: Mon, 29 Jul 2019 18:46:04 +0200 From: Cornelia Huck To: "Dr. David Alan Gilbert (git)" Message-ID: <20190729184604.3981788b.cohuck@redhat.com> In-Reply-To: <20190729162903.4489-2-dgilbert@redhat.com> References: <20190729162903.4489-1-dgilbert@redhat.com> <20190729162903.4489-2-dgilbert@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 29 Jul 2019 16:46:09 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 1/2] Revert "Revert "globals: Allow global properties to be optional"" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, qemu-devel@nongnu.org, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 29 Jul 2019 17:29:02 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > This reverts commit 8fa70dbd8bb478d9483c1da3e9976a2d86b3f9a0. > > Because we're about to revert it's neighbour and thus uses an optional > again. > > Signed-off-by: Dr. David Alan Gilbert > --- > include/hw/qdev-core.h | 3 +++ > qom/object.c | 3 +++ > 2 files changed, 6 insertions(+) As discussed on IRC, the 'bugs' mentioned in that commit were related to the other patch that is being reverted; so I don't really mind it for 4.1 (IOW, either of the two revert approaches should be fine.) Reviewed-by: Cornelia Huck