From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC50C7618B for ; Mon, 29 Jul 2019 16:50:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79E4F206A2 for ; Mon, 29 Jul 2019 16:50:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79E4F206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55170 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs8rE-00042w-Ry for qemu-devel@archiver.kernel.org; Mon, 29 Jul 2019 12:50:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34018) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hs8nV-0008PJ-HP for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:46:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hs8nU-0001N8-5W for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:46:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50320) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hs8nU-0001Lr-0C for qemu-devel@nongnu.org; Mon, 29 Jul 2019 12:46:52 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B603D8666C for ; Mon, 29 Jul 2019 16:46:48 +0000 (UTC) Received: from gondolin (dhcp-192-232.str.redhat.com [10.33.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FD9210013A1; Mon, 29 Jul 2019 16:46:45 +0000 (UTC) Date: Mon, 29 Jul 2019 18:46:43 +0200 From: Cornelia Huck To: "Dr. David Alan Gilbert (git)" Message-ID: <20190729184643.5c1b04a9.cohuck@redhat.com> In-Reply-To: <20190729162903.4489-3-dgilbert@redhat.com> References: <20190729162903.4489-1-dgilbert@redhat.com> <20190729162903.4489-3-dgilbert@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 29 Jul 2019 16:46:48 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v2 2/2] Revert "hw: report invalid disable-legacy|modern usage for virtio-1-only devs" X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: berrange@redhat.com, qemu-devel@nongnu.org, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 29 Jul 2019 17:29:03 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > This reverts commit f2784eed306449c3d04a71a05ed6463b8289aedf > since that accidentally removes the PCIe capabilities from virtio > devices because virtio_pci_dc_realize is called before the new 'mode' > flag is set. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/core/machine.c | 23 +++-------------------- > hw/display/virtio-gpu-pci.c | 4 +--- > hw/display/virtio-vga.c | 4 +--- > hw/virtio/virtio-crypto-pci.c | 4 +--- > hw/virtio/virtio-input-pci.c | 4 +--- > hw/virtio/virtio-pci.c | 26 ++++++++++---------------- > hw/virtio/virtio-pci.h | 31 ++++++------------------------- > 7 files changed, 23 insertions(+), 73 deletions(-) Reviewed-by: Cornelia Huck