From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62235C433FF for ; Tue, 30 Jul 2019 00:43:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36AD420651 for ; Tue, 30 Jul 2019 00:43:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36AD420651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsGEH-0006UO-Gm for qemu-devel@archiver.kernel.org; Mon, 29 Jul 2019 20:43:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60515) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsGDf-00061v-5L for qemu-devel@nongnu.org; Mon, 29 Jul 2019 20:42:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsGDe-0002zr-7N for qemu-devel@nongnu.org; Mon, 29 Jul 2019 20:42:23 -0400 Received: from mga04.intel.com ([192.55.52.120]:23076) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsGDd-0002yd-Uo for qemu-devel@nongnu.org; Mon, 29 Jul 2019 20:42:22 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2019 17:42:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,324,1559545200"; d="scan'208";a="182953515" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga002.jf.intel.com with ESMTP; 29 Jul 2019 17:42:19 -0700 Date: Tue, 30 Jul 2019 08:41:57 +0800 From: Wei Yang To: Ivan Ren Message-ID: <20190730004157.GB17604@richard> References: <1564387281-12321-1-git-send-email-ivanren@tencent.com> <1564387281-12321-4-git-send-email-ivanren@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1564387281-12321-4-git-send-email-ivanren@tencent.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.120 Subject: Re: [Qemu-devel] [PATCH v2 3/3] migration: update ram_counters for multifd sync packet X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 29, 2019 at 04:01:21PM +0800, Ivan Ren wrote: >Multifd sync will send MULTIFD_FLAG_SYNC flag info to destination, add >these bytes to ram_counters record. > >Signed-off-by: Ivan Ren Also this is suggested by me, it would be better to add Suggested-by. >--- > migration/ram.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/migration/ram.c b/migration/ram.c >index 88ddd2bbe2..20b6eebb7c 100644 >--- a/migration/ram.c >+++ b/migration/ram.c >@@ -1085,6 +1085,8 @@ static void multifd_send_sync_main(RAMState *rs) > p->flags |= MULTIFD_FLAG_SYNC; > p->pending_job++; > qemu_file_update_transfer(rs->f, p->packet_len); >+ ram_counters.multifd_bytes += p->packet_len; >+ ram_counters.transferred += p->packet_len; > qemu_mutex_unlock(&p->mutex); > qemu_sem_post(&p->sem); > } >-- >2.17.2 (Apple Git-113) > -- Wei Yang Help you, Help me