From: Stefan Hajnoczi <stefanha@gmail.com>
To: Aarushi Mehta <mehta.aaru20@gmail.com>
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefan@redhat.com>,
qemu-block@nongnu.org, Sergio Lopez <slp@redhat.com>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
saket.sinha89@gmail.com, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Julia Suvorova <jusual@mail.ru>
Subject: Re: [Qemu-devel] [PATCH v7 04/15] block/io_uring: implements interfaces for io_uring
Date: Tue, 30 Jul 2019 08:28:29 +0100 [thread overview]
Message-ID: <20190730072829.GB30213@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190729151651.21306-5-mehta.aaru20@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 575 bytes --]
On Mon, Jul 29, 2019 at 08:46:40PM +0530, Aarushi Mehta wrote:
> +/**
> + * luring_process_completions:
> + * @s: AIO state
> + *
> + * Fetches completed I/O requests, consumes cqes and invokes their callbacks
> + * The function is somewhat tricky because it supports nested event loops, for
> + * example when a request callback invokes aio_poll(). In order to do this,
> + * indices are kept in LuringState. Function schedules BH completion so it
The sentence about indices is outdated and can be removed.
Otherwise:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-30 7:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 15:16 [Qemu-devel] [PATCH v7 00/15] Add support for io_uring Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 01/15] configure: permit use of io_uring Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 02/15] qapi/block-core: add option for io_uring Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 03/15] block/block: add BDRV flag " Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 04/15] block/io_uring: implements interfaces " Aarushi Mehta
2019-07-30 7:28 ` Stefan Hajnoczi [this message]
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 05/15] stubs: add stubs for io_uring interface Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 06/15] util/async: add aio interfaces for io_uring Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 07/15] blockdev: adds bdrv_parse_aio to use io_uring Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 08/15] block/file-posix.c: extend " Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 09/15] block: add trace events for io_uring Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 10/15] block/io_uring: adds userspace completion polling Aarushi Mehta
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 11/15] qemu-io: adds option to use aio engine Aarushi Mehta
2019-07-30 7:34 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 12/15] qemu-img: adds option to use aio engine for benchmarking Aarushi Mehta
2019-07-30 7:37 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 13/15] qemu-nbd: adds option for aio engines Aarushi Mehta
2019-07-30 7:38 ` Stefan Hajnoczi
2019-07-30 13:01 ` Eric Blake
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 14/15] tests/qemu-iotests: enable testing with aio options Aarushi Mehta
2019-07-30 7:41 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2019-07-29 15:16 ` [Qemu-devel] [PATCH v7 15/15] tests/qemu-iotests: use AIOMODE with various tests Aarushi Mehta
2019-07-30 7:43 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730072829.GB30213@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=fam@euphon.net \
--cc=jusual@mail.ru \
--cc=kwolf@redhat.com \
--cc=mehta.aaru20@gmail.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=saket.sinha89@gmail.com \
--cc=slp@redhat.com \
--cc=stefan@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).