From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61238C0650F for ; Tue, 30 Jul 2019 12:05:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 375D320693 for ; Tue, 30 Jul 2019 12:05:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 375D320693 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsQt3-00058h-H5 for qemu-devel@archiver.kernel.org; Tue, 30 Jul 2019 08:05:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59347) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsQsa-0004b2-QV for qemu-devel@nongnu.org; Tue, 30 Jul 2019 08:05:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsQsZ-000108-2Q for qemu-devel@nongnu.org; Tue, 30 Jul 2019 08:05:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12956) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hsQsY-0000z4-T6 for qemu-devel@nongnu.org; Tue, 30 Jul 2019 08:05:19 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 588C920260 for ; Tue, 30 Jul 2019 12:05:17 +0000 (UTC) Received: from Igors-MacBook-Pro (ovpn-204-67.brq.redhat.com [10.40.204.67]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7DD98600CC; Tue, 30 Jul 2019 12:05:13 +0000 (UTC) Date: Tue, 30 Jul 2019 14:05:11 +0200 From: Igor Mammedov To: "Dr. David Alan Gilbert (git)" Message-ID: <20190730140511.31decaac@Igors-MacBook-Pro> In-Reply-To: <20190730093719.12958-3-dgilbert@redhat.com> References: <20190730093719.12958-1-dgilbert@redhat.com> <20190730093719.12958-3-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 30 Jul 2019 12:05:17 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 2/2] pcie_root_port: Disable ACS on older machines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quintela@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, 30 Jul 2019 10:37:19 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > ACS got added in 4.0 unconditionally, that broke older<->4.0 migration > where there was a PCIe root port. > Fix this by turning it off for 3.1 and older machines; note this > fixes compatibility for older QEMUs but breaks compatibility with 4.0 > for older machine types. > > machine type source qemu dest qemu > 3.1 3.1 4.0 broken > 3.1 3.1 4.1rc2 broken > 3.1 3.1 4.1+this OK ++ > 3.1 4.0 4.1rc2 OK > 3.1 4.0 4.1+this broken -- > 4.0 4.0 4.1rc2 OK > 4.0 4.0 4.1+this OK > > So we gain and lose; the consensus seems to be treat this as a > fix for older machine types. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Igor Mammedov > --- > hw/core/machine.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/core/machine.c b/hw/core/machine.c > index c58a8e594e..26a5f30e6d 100644 > --- a/hw/core/machine.c > +++ b/hw/core/machine.c > @@ -52,6 +52,7 @@ GlobalProperty hw_compat_3_1[] = { > { "virtio-blk-device", "discard", "false" }, > { "virtio-blk-device", "write-zeroes", "false" }, > { "virtio-balloon-device", "qemu-4-0-config-size", "false" }, > + { "pcie-root-port-base", "disable-acs", "true" }, /* Added in 4.1 */ > }; > const size_t hw_compat_3_1_len = G_N_ELEMENTS(hw_compat_3_1); >