From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24BB9C433FF for ; Wed, 31 Jul 2019 18:02:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9BCE2067D for ; Wed, 31 Jul 2019 18:02:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mPI1b4Bd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9BCE2067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hssvT-0002Yt-87 for qemu-devel@archiver.kernel.org; Wed, 31 Jul 2019 14:02:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42844) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hssrH-0002N0-KB for qemu-devel@nongnu.org; Wed, 31 Jul 2019 13:57:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hssrG-0002rz-CZ for qemu-devel@nongnu.org; Wed, 31 Jul 2019 13:57:51 -0400 Received: from mail-yb1-xb41.google.com ([2607:f8b0:4864:20::b41]:39086) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hssrG-0002r1-8C for qemu-devel@nongnu.org; Wed, 31 Jul 2019 13:57:50 -0400 Received: by mail-yb1-xb41.google.com with SMTP id z128so2573679yba.6 for ; Wed, 31 Jul 2019 10:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LvfVVm1R1i5TWS3AOjieQ7QlUKuT8clHbsVMx2FutBg=; b=mPI1b4BdBuyMd+z8QdDfpNkvZyaM5PZcyO+9qRFqSUx+XV9ErrHsdqw83B0on9wty9 5PdREDB7e14gQY4ob/1qKU5Up7i0n53rqaycWOMS0O3a5JxpRkCg5K8N2uDrtsrGC5qr vMe3Q928cIsgYBzcWqBIOYrvYpVf6AQ80QwvTcVQdO32H1TzhhdRhQEw7ZIXyDstoDow 5nwOqf4W8Smrrxzx0eNGkAnLvrTdSaD02vUY7HBnaJqavWZHnYS8qgqLeYmURT1zSoDW a+VUeLXSsMFpM6yeOfYy8t/ix2Rtr09GfqHebTkyh5DxtsTPpceg+zhIDG4eB6nLeB1S ORUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LvfVVm1R1i5TWS3AOjieQ7QlUKuT8clHbsVMx2FutBg=; b=NNrmdTQzYy9hc/LiRTIo4SEviLI2R5n44HOVVrqghhN2fx+haxy7yamRAJLii/atpw uD+GAlGVtE3mUNpqIGVZbVQHnPLkwLZoWwspJtlCer81QVwqLWJsanseS/ybWPYOKJQh OgnuQpWj7yy1h06u8/PbNK8nrOBQjt/UFgVgNYhjMn7Bp7kIrhrpPKSw/xrr99d8C9Gz sHyhaHnsKtkpOWf4nQJqR+Q4Iaokzy1HHrbizPb/zT5b539JuqZI/+OhS2EjsFVrNKXN M9GmKbY/nxHcExxz1ZVjO/KYD9WRH8WqqBrhsTNeSWUt0zXioPYyWkKfzTFBFsBpKqIA 2mlw== X-Gm-Message-State: APjAAAX9pJsriXGB+DhyouTXLEGBkKMZzXmtHj/g7ZE9PyktRZ/TxuNS 1xDgfPoTbFUa/fiPwsPgpcVhh9C/ X-Google-Smtp-Source: APXvYqzpKtDX0hnj1kIajPI0khLumwvWsYATgroxsmSK864aT66+ShjbHij5XNcpbHfApdj6yH2+cA== X-Received: by 2002:a5b:792:: with SMTP id b18mr62858185ybq.498.1564595869520; Wed, 31 Jul 2019 10:57:49 -0700 (PDT) Received: from dionysus.attlocal.net (69-222-133-165.lightspeed.tukrga.sbcglobal.net. [69.222.133.165]) by smtp.gmail.com with ESMTPSA id 206sm16077696ywk.44.2019.07.31.10.57.49 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 31 Jul 2019 10:57:49 -0700 (PDT) From: Jan Bobek To: qemu-devel@nongnu.org Date: Wed, 31 Jul 2019 13:56:54 -0400 Message-Id: <20190731175702.4916-15-jan.bobek@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190731175702.4916-1-jan.bobek@gmail.com> References: <20190731175702.4916-1-jan.bobek@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::b41 Subject: [Qemu-devel] [RFC PATCH v1 14/22] target/i386: reimplement (V)PADDS(B, W) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Jan Bobek Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Use the gvec infrastructure to achieve the desired functionality. Signed-off-by: Jan Bobek --- target/i386/ops_sse.h | 4 ---- target/i386/ops_sse_header.h | 2 -- target/i386/translate.c | 19 +++++++++++++++++-- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 59935a65be..8829dcb781 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -339,8 +339,6 @@ static inline int satsw(int x) #define FADDUB(a, b) satub((a) + (b)) #define FADDUW(a, b) satuw((a) + (b)) -#define FADDSB(a, b) satsb((int8_t)(a) + (int8_t)(b)) -#define FADDSW(a, b) satsw((int16_t)(a) + (int16_t)(b)) #define FSUBUB(a, b) satub((a) - (b)) #define FSUBUW(a, b) satuw((a) - (b)) @@ -365,12 +363,10 @@ static inline int satsw(int x) #endif SSE_HELPER_B(helper_paddusb, FADDUB) -SSE_HELPER_B(helper_paddsb, FADDSB) SSE_HELPER_B(helper_psubusb, FSUBUB) SSE_HELPER_B(helper_psubsb, FSUBSB) SSE_HELPER_W(helper_paddusw, FADDUW) -SSE_HELPER_W(helper_paddsw, FADDSW) SSE_HELPER_W(helper_psubusw, FSUBUW) SSE_HELPER_W(helper_psubsw, FSUBSW) diff --git a/target/i386/ops_sse_header.h b/target/i386/ops_sse_header.h index bcdbac99a0..78203e80a5 100644 --- a/target/i386/ops_sse_header.h +++ b/target/i386/ops_sse_header.h @@ -61,12 +61,10 @@ DEF_HELPER_3(glue(pslldq, SUFFIX), void, env, Reg, Reg) DEF_HELPER_3(glue(name, SUFFIX), void, env, Reg, Reg) SSE_HELPER_B(paddusb, FADDUB) -SSE_HELPER_B(paddsb, FADDSB) SSE_HELPER_B(psubusb, FSUBUB) SSE_HELPER_B(psubsb, FSUBSB) SSE_HELPER_W(paddusw, FADDUW) -SSE_HELPER_W(paddsw, FADDSW) SSE_HELPER_W(psubusw, FSUBUW) SSE_HELPER_W(psubsw, FSUBSW) diff --git a/target/i386/translate.c b/target/i386/translate.c index 6f4dfd06a1..5ea5014d99 100644 --- a/target/i386/translate.c +++ b/target/i386/translate.c @@ -2842,8 +2842,8 @@ static const SSEFunc_0_epp sse_op_table1[256][4] = { [0xe9] = MMX_OP2(psubsw), [0xea] = MMX_OP2(pminsw), [0xeb] = { SSE_TOMBSTONE, SSE_TOMBSTONE }, - [0xec] = MMX_OP2(paddsb), - [0xed] = MMX_OP2(paddsw), + [0xec] = { SSE_TOMBSTONE, SSE_TOMBSTONE }, + [0xed] = { SSE_TOMBSTONE, SSE_TOMBSTONE }, [0xee] = MMX_OP2(pmaxsw), [0xef] = { SSE_TOMBSTONE, SSE_TOMBSTONE }, [0xf0] = { NULL, NULL, NULL, SSE_SPECIAL }, /* lddqu */ @@ -3171,6 +3171,11 @@ static inline void gen_gvec_ld_modrm_3(CPUX86State *env, DisasContext *s, #define gen_vpadd_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), (modrm), (vece), tcg_gen_gvec_add, 0123) #define gen_vpadd_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), (modrm), (vece), tcg_gen_gvec_add, 0123) +#define gen_padds_mm(env, s, modrm, vece) gen_gvec_ld_modrm_mm ((env), (s), (modrm), (vece), tcg_gen_gvec_ssadd, 0112) +#define gen_padds_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_xmm ((env), (s), (modrm), (vece), tcg_gen_gvec_ssadd, 0112) +#define gen_vpadds_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), (modrm), (vece), tcg_gen_gvec_ssadd, 0123) +#define gen_vpadds_ymm(env, s, modrm, vece) gen_gvec_ld_modrm_vymm((env), (s), (modrm), (vece), tcg_gen_gvec_ssadd, 0123) + #define gen_psub_mm(env, s, modrm, vece) gen_gvec_ld_modrm_mm ((env), (s), (modrm), (vece), tcg_gen_gvec_sub, 0112) #define gen_psub_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_xmm ((env), (s), (modrm), (vece), tcg_gen_gvec_sub, 0112) #define gen_vpsub_xmm(env, s, modrm, vece) gen_gvec_ld_modrm_vxmm((env), (s), (modrm), (vece), tcg_gen_gvec_sub, 0123) @@ -3331,6 +3336,16 @@ static void gen_sse(CPUX86State *env, DisasContext *s, int b) case 0xd4 | M_0F | P_66 | VEX_128: gen_vpadd_xmm(env, s, modrm, MO_64); return; case 0xd4 | M_0F | P_66 | VEX_256: gen_vpadd_ymm(env, s, modrm, MO_64); return; + case 0xec | M_0F: gen_padds_mm(env, s, modrm, MO_8); return; + case 0xec | M_0F | P_66: gen_padds_xmm(env, s, modrm, MO_8); return; + case 0xec | M_0F | P_66 | VEX_128: gen_vpadds_xmm(env, s, modrm, MO_8); return; + case 0xec | M_0F | P_66 | VEX_256: gen_vpadds_ymm(env, s, modrm, MO_8); return; + + case 0xed | M_0F: gen_padds_mm(env, s, modrm, MO_16); return; + case 0xed | M_0F | P_66: gen_padds_xmm(env, s, modrm, MO_16); return; + case 0xed | M_0F | P_66 | VEX_128: gen_vpadds_xmm(env, s, modrm, MO_16); return; + case 0xed | M_0F | P_66 | VEX_256: gen_vpadds_ymm(env, s, modrm, MO_16); return; + case 0xf8 | M_0F: gen_psub_mm(env, s, modrm, MO_8); return; case 0xf8 | M_0F | P_66: gen_psub_xmm(env, s, modrm, MO_8); return; case 0xf8 | M_0F | P_66 | VEX_128: gen_vpsub_xmm(env, s, modrm, MO_8); return; -- 2.20.1