From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH for-4.1 0/2] backup: Copy only dirty areas
Date: Thu, 1 Aug 2019 17:12:33 +0200 [thread overview]
Message-ID: <20190801151235.8434-1-mreitz@redhat.com> (raw)
Hi,
In a discussion with Vladimir today, we noticed that the backup job
currently is pretty broken when using copy offloading. I don’t know
about you, but my local filesystem (XFS) supports copy offloading, so
the job uses it automatically. That means, that backup is broken and
has been broken for a year on my local FS.
The last working version was 2.12, so this isn’t a regression in 4.1.
We could thus justify moving it to 4.2. But I think this should really
go into 4.1, because this is not really an edge case and as far as I
know users cannot do anything to prevent the backup job from performing
copy offloading if the system and all involved block drivers support it.
I just wonder why nobody has noticed...
Max Reitz (2):
backup: Copy only dirty areas
iotests: Test backup job with two guest writes
block/backup.c | 13 +++++++++++--
tests/qemu-iotests/056 | 34 ++++++++++++++++++++++++++++++++++
tests/qemu-iotests/056.out | 4 ++--
3 files changed, 47 insertions(+), 4 deletions(-)
--
2.21.0
next reply other threads:[~2019-08-01 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 15:12 Max Reitz [this message]
2019-08-01 15:12 ` [Qemu-devel] [PATCH for-4.1 1/2] backup: Copy only dirty areas Max Reitz
2019-08-01 15:37 ` Vladimir Sementsov-Ogievskiy
2019-08-01 15:12 ` [Qemu-devel] [PATCH for-4.1 2/2] iotests: Test backup job with two guest writes Max Reitz
2019-08-01 16:03 ` Vladimir Sementsov-Ogievskiy
2019-08-01 17:06 ` Max Reitz
2019-08-01 17:25 ` Vladimir Sementsov-Ogievskiy
2019-08-01 17:35 ` Max Reitz
2019-08-01 17:43 ` Vladimir Sementsov-Ogievskiy
2019-08-01 17:56 ` Vladimir Sementsov-Ogievskiy
2019-08-01 16:33 ` [Qemu-devel] [PATCH for-4.1 0/2] backup: Copy only dirty areas Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801151235.8434-1-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).