From: Wei Yang <richardw.yang@linux.intel.com>
To: Ivan Ren <renyime@gmail.com>
Cc: quintela@redhat.com, Wei Yang <richardw.yang@linux.intel.com>,
dgilbert@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration
Date: Fri, 2 Aug 2019 08:49:04 +0800 [thread overview]
Message-ID: <20190802004904.GA20638@richard> (raw)
In-Reply-To: <CA+6E1==Dc5Zac3Q-tt2V2pbq-DofW=AZX6tP1RoDBp4KSNxiKw@mail.gmail.com>
On Thu, Aug 01, 2019 at 04:10:34PM +0800, Ivan Ren wrote:
>>> s->iteration_start_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
>>>+ /*
>>>+ * Update s->iteration_initial_bytes to match
>s->iteration_start_time.
>>>+ */
>>>+ s->iteration_initial_bytes = migration_total_bytes(s);
>>
>>Is this one necessary? We have sent out nothing yet.
>
>Yes, currently nothing has been sent yet at this point.
>
>Is that better to always match the update of iteration_initial_bytes
>and iteration_start_time in a explicit way to avoid some potential missing?
>
You may get some point. Well after a close look, we may find other potential
problem.
1. To be consistency, we need to update iteration_initial_pages too.
So my opinion is to wrap the update of these three counters into a helper
function. So each time all of them.
2. In function ram_get_total_transferred_pages, do we missed multifd_bytes?
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-08-02 0:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 5:36 [Qemu-devel] [PATCH] migration: always initial ram_counters for a new migration Ivan Ren
2019-07-30 15:56 ` Juan Quintela
2019-08-01 2:21 ` Wei Yang
2019-08-01 8:10 ` Ivan Ren
2019-08-02 0:49 ` Wei Yang [this message]
2019-08-02 5:46 ` Ivan Ren
2019-08-02 5:59 ` Wei Yang
2019-08-02 6:37 ` Ivan Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190802004904.GA20638@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=renyime@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).