qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richardw.yang@linux.intel.com>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()
Date: Mon, 5 Aug 2019 10:03:46 +0800	[thread overview]
Message-ID: <20190805020346.GA18220@richard> (raw)
In-Reply-To: <20190711080816.6405-1-richardw.yang@linux.intel.com>

On Thu, Jul 11, 2019 at 04:08:16PM +0800, Wei Yang wrote:
>PostcopyState is already set to ADVISE at the beginning of
>loadvm_postcopy_handle_advise().
>
>Remove the redundant set.

Ping~

>
>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>---
> migration/savevm.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/migration/savevm.c b/migration/savevm.c
>index 8a2ada529e..2350e219fc 100644
>--- a/migration/savevm.c
>+++ b/migration/savevm.c
>@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
>         return -1;
>     }
> 
>-    postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
>-
>     return 0;
> }
> 
>-- 
>2.17.1

-- 
Wei Yang
Help you, Help me


  reply	other threads:[~2019-08-05  2:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11  8:08 [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise() Wei Yang
2019-08-05  2:03 ` Wei Yang [this message]
2019-08-05  9:34 ` Dr. David Alan Gilbert
2019-08-07 17:34 ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190805020346.GA18220@richard \
    --to=richardw.yang@linux.intel.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).