From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BCBFC433FF for ; Mon, 5 Aug 2019 02:05:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32AA920B1F for ; Mon, 5 Aug 2019 02:05:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32AA920B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huSN5-00025L-AM for qemu-devel@archiver.kernel.org; Sun, 04 Aug 2019 22:05:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49842) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1huSMf-0001ZD-65 for qemu-devel@nongnu.org; Sun, 04 Aug 2019 22:04:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1huSMe-0006M3-8A for qemu-devel@nongnu.org; Sun, 04 Aug 2019 22:04:45 -0400 Received: from mga03.intel.com ([134.134.136.65]:13970) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1huSMe-0006L2-0p for qemu-devel@nongnu.org; Sun, 04 Aug 2019 22:04:44 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2019 19:04:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,348,1559545200"; d="scan'208";a="185170794" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga002.jf.intel.com with ESMTP; 04 Aug 2019 19:04:14 -0700 Date: Mon, 5 Aug 2019 10:03:46 +0800 From: Wei Yang To: Wei Yang Message-ID: <20190805020346.GA18220@richard> References: <20190711080816.6405-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190711080816.6405-1-richardw.yang@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 134.134.136.65 Subject: Re: [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, quintela@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 11, 2019 at 04:08:16PM +0800, Wei Yang wrote: >PostcopyState is already set to ADVISE at the beginning of >loadvm_postcopy_handle_advise(). > >Remove the redundant set. Ping~ > >Signed-off-by: Wei Yang >--- > migration/savevm.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/migration/savevm.c b/migration/savevm.c >index 8a2ada529e..2350e219fc 100644 >--- a/migration/savevm.c >+++ b/migration/savevm.c >@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis, > return -1; > } > >- postcopy_state_set(POSTCOPY_INCOMING_ADVISE); >- > return 0; > } > >-- >2.17.1 -- Wei Yang Help you, Help me