* [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()
@ 2019-07-11 8:08 Wei Yang
2019-08-05 2:03 ` Wei Yang
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yang @ 2019-07-11 8:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Wei Yang, dgilbert, quintela
PostcopyState is already set to ADVISE at the beginning of
loadvm_postcopy_handle_advise().
Remove the redundant set.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
migration/savevm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 8a2ada529e..2350e219fc 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
return -1;
}
- postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
-
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()
2019-07-11 8:08 [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise() Wei Yang
@ 2019-08-05 2:03 ` Wei Yang
2019-08-05 9:34 ` Dr. David Alan Gilbert
2019-08-07 17:34 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Wei Yang @ 2019-08-05 2:03 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, dgilbert, quintela
On Thu, Jul 11, 2019 at 04:08:16PM +0800, Wei Yang wrote:
>PostcopyState is already set to ADVISE at the beginning of
>loadvm_postcopy_handle_advise().
>
>Remove the redundant set.
Ping~
>
>Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
>---
> migration/savevm.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/migration/savevm.c b/migration/savevm.c
>index 8a2ada529e..2350e219fc 100644
>--- a/migration/savevm.c
>+++ b/migration/savevm.c
>@@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
> return -1;
> }
>
>- postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
>-
> return 0;
> }
>
>--
>2.17.1
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()
2019-07-11 8:08 [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise() Wei Yang
2019-08-05 2:03 ` Wei Yang
@ 2019-08-05 9:34 ` Dr. David Alan Gilbert
2019-08-07 17:34 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2019-08-05 9:34 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, quintela
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> PostcopyState is already set to ADVISE at the beginning of
> loadvm_postcopy_handle_advise().
>
> Remove the redundant set.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/savevm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 8a2ada529e..2350e219fc 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
> return -1;
> }
>
> - postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
> -
> return 0;
> }
>
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise()
2019-07-11 8:08 [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise() Wei Yang
2019-08-05 2:03 ` Wei Yang
2019-08-05 9:34 ` Dr. David Alan Gilbert
@ 2019-08-07 17:34 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2019-08-07 17:34 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, quintela
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> PostcopyState is already set to ADVISE at the beginning of
> loadvm_postcopy_handle_advise().
>
> Remove the redundant set.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Queued
> ---
> migration/savevm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 8a2ada529e..2350e219fc 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1648,8 +1648,6 @@ static int loadvm_postcopy_handle_advise(MigrationIncomingState *mis,
> return -1;
> }
>
> - postcopy_state_set(POSTCOPY_INCOMING_ADVISE);
> -
> return 0;
> }
>
> --
> 2.17.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-07 17:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-11 8:08 [Qemu-devel] [PATCH] migration/postcopy: PostcopyState is already set in loadvm_postcopy_handle_advise() Wei Yang
2019-08-05 2:03 ` Wei Yang
2019-08-05 9:34 ` Dr. David Alan Gilbert
2019-08-07 17:34 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).