* [Qemu-devel] [PATCH v3] hmp: Remove migration capabilities from "info migrate"
@ 2019-08-06 0:36 Wei Yang
2019-08-06 10:23 ` Dr. David Alan Gilbert
2019-08-07 18:44 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yang @ 2019-08-06 0:36 UTC (permalink / raw)
To: qemu-devel; +Cc: Wei Yang, dgilbert, armbru
With the growth of migration capabilities, it is not proper to display
them in "info migrate". Users are recommended to use "info
migrate_capabiltiies" to list them.
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
v3:
* remove un-used variable caps
v2:
* remove capabilities from "info migrate"
---
monitor/hmp-cmds.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 5ca3ebe942..35788c0645 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -220,24 +220,11 @@ static char *SocketAddress_to_str(SocketAddress *addr)
void hmp_info_migrate(Monitor *mon, const QDict *qdict)
{
MigrationInfo *info;
- MigrationCapabilityStatusList *caps, *cap;
info = qmp_query_migrate(NULL);
- caps = qmp_query_migrate_capabilities(NULL);
migration_global_dump(mon);
- /* do not display parameters during setup */
- if (info->has_status && caps) {
- monitor_printf(mon, "capabilities: ");
- for (cap = caps; cap; cap = cap->next) {
- monitor_printf(mon, "%s: %s ",
- MigrationCapability_str(cap->value->capability),
- cap->value->state ? "on" : "off");
- }
- monitor_printf(mon, "\n");
- }
-
if (info->has_status) {
monitor_printf(mon, "Migration status: %s",
MigrationStatus_str(info->status));
@@ -370,7 +357,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
monitor_printf(mon, "]\n");
}
qapi_free_MigrationInfo(info);
- qapi_free_MigrationCapabilityStatusList(caps);
}
void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v3] hmp: Remove migration capabilities from "info migrate"
2019-08-06 0:36 [Qemu-devel] [PATCH v3] hmp: Remove migration capabilities from "info migrate" Wei Yang
@ 2019-08-06 10:23 ` Dr. David Alan Gilbert
2019-08-07 18:44 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-08-06 10:23 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, armbru
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> With the growth of migration capabilities, it is not proper to display
> them in "info migrate". Users are recommended to use "info
> migrate_capabiltiies" to list them.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> ---
> v3:
> * remove un-used variable caps
> v2:
> * remove capabilities from "info migrate"
> ---
> monitor/hmp-cmds.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 5ca3ebe942..35788c0645 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -220,24 +220,11 @@ static char *SocketAddress_to_str(SocketAddress *addr)
> void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> {
> MigrationInfo *info;
> - MigrationCapabilityStatusList *caps, *cap;
>
> info = qmp_query_migrate(NULL);
> - caps = qmp_query_migrate_capabilities(NULL);
>
> migration_global_dump(mon);
>
> - /* do not display parameters during setup */
> - if (info->has_status && caps) {
> - monitor_printf(mon, "capabilities: ");
> - for (cap = caps; cap; cap = cap->next) {
> - monitor_printf(mon, "%s: %s ",
> - MigrationCapability_str(cap->value->capability),
> - cap->value->state ? "on" : "off");
> - }
> - monitor_printf(mon, "\n");
> - }
> -
> if (info->has_status) {
> monitor_printf(mon, "Migration status: %s",
> MigrationStatus_str(info->status));
> @@ -370,7 +357,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "]\n");
> }
> qapi_free_MigrationInfo(info);
> - qapi_free_MigrationCapabilityStatusList(caps);
> }
>
> void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)
> --
> 2.17.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH v3] hmp: Remove migration capabilities from "info migrate"
2019-08-06 0:36 [Qemu-devel] [PATCH v3] hmp: Remove migration capabilities from "info migrate" Wei Yang
2019-08-06 10:23 ` Dr. David Alan Gilbert
@ 2019-08-07 18:44 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2019-08-07 18:44 UTC (permalink / raw)
To: Wei Yang; +Cc: qemu-devel, armbru
* Wei Yang (richardw.yang@linux.intel.com) wrote:
> With the growth of migration capabilities, it is not proper to display
> them in "info migrate". Users are recommended to use "info
> migrate_capabiltiies" to list them.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Suggested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> v3:
> * remove un-used variable caps
> v2:
> * remove capabilities from "info migrate"
> ---
> monitor/hmp-cmds.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 5ca3ebe942..35788c0645 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -220,24 +220,11 @@ static char *SocketAddress_to_str(SocketAddress *addr)
> void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> {
> MigrationInfo *info;
> - MigrationCapabilityStatusList *caps, *cap;
>
> info = qmp_query_migrate(NULL);
> - caps = qmp_query_migrate_capabilities(NULL);
>
> migration_global_dump(mon);
>
> - /* do not display parameters during setup */
> - if (info->has_status && caps) {
> - monitor_printf(mon, "capabilities: ");
> - for (cap = caps; cap; cap = cap->next) {
> - monitor_printf(mon, "%s: %s ",
> - MigrationCapability_str(cap->value->capability),
> - cap->value->state ? "on" : "off");
> - }
> - monitor_printf(mon, "\n");
> - }
> -
> if (info->has_status) {
> monitor_printf(mon, "Migration status: %s",
> MigrationStatus_str(info->status));
> @@ -370,7 +357,6 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict)
> monitor_printf(mon, "]\n");
> }
> qapi_free_MigrationInfo(info);
> - qapi_free_MigrationCapabilityStatusList(caps);
> }
>
> void hmp_info_migrate_capabilities(Monitor *mon, const QDict *qdict)
> --
> 2.17.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-07 18:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-06 0:36 [Qemu-devel] [PATCH v3] hmp: Remove migration capabilities from "info migrate" Wei Yang
2019-08-06 10:23 ` Dr. David Alan Gilbert
2019-08-07 18:44 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).